Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/WebKit/LayoutTests/inspector/console/console-filter-groups.html

Issue 2939473002: DevTools: show all descendants if a console.group message title matches the filter
Patch Set: aaa Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/inspector/console/console-filter-groups-expected.txt » ('j') | third_party/WebKit/LayoutTests/inspector/console/console-filter-groups-expected.txt » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/inspector/console/console-filter-groups.html
diff --git a/third_party/WebKit/LayoutTests/inspector/console/console-filter-groups.html b/third_party/WebKit/LayoutTests/inspector/console/console-filter-groups.html
new file mode 100644
index 0000000000000000000000000000000000000000..8fb6566304d7586891426f92041bab38ee9c9dc9
--- /dev/null
+++ b/third_party/WebKit/LayoutTests/inspector/console/console-filter-groups.html
@@ -0,0 +1,131 @@
+<html>
+<head>
+<script src="../../http/tests/inspector/inspector-test.js"></script>
+<script src="../../http/tests/inspector/console-test.js"></script>
+<script>
+console.group('Outer group-A');
+ console.log('message-a1');
+ console.log('message-a2');
+
+ console.group('Inner group-B');
+ console.log('message-b1');
+ console.log('message-b2');
+ console.groupEnd();
+
+ console.group('Inner group-C');
+ console.log('message-c1');
+ console.log('message-c2');
+ console.groupEnd();
+
+ console.groupCollapsed('Collapsed inner group-D');
+ console.log('message-d1');
+ console.log('message-d2');
+
+ console.group('Inner inner group-E');
+ console.log('message-e1');
+ console.log('message-e2');
+ console.groupEnd();
+ console.groupEnd();
+
+console.groupEnd();
+
+console.groupCollapsed('Collapsed outer group-F');
+ console.log('message-f1');
+ console.log('message-f2');
+console.groupEnd();
+
+console.log('message-z1');
+console.log('message-z2');
+
+</script>
+<script>
+function test()
+{
+ var testcases = [
+ '/message-a1/',
+ '/message-b1/',
+ '/message-c1/',
+ '/message-d1/',
+ '/message-e1/',
+ '/message-f1/',
+ '/message-z1/',
+ '/message-a1|message-b1/',
+ '/message-a1|message-c1/',
+ '/message-a1|message-d1/',
+ '/message-a1|message-e1/',
+ '/message-a1|message-z1/',
+ '/message-b1|message-c1/',
+ '/message-b1|message-d1/',
+ '/message-b1|message-z1/',
+ '/message-c1|message-z1/',
+ '/message-d1|message-e1/',
+
+ '/group-A/',
+ '/group-B/',
+ '/group-C/',
+ '/group-D/',
+ '/group-E/',
+ '/group-F/',
+
+ '/group-A|group-B/',
+ '/group-A|group-E/',
+ '/group-B|group-C/',
+ '/group-B|group-D/',
+ '/group-B|group-E/',
+ '/group-D|group-E/',
+
+ '/group-A|message-b1/',
+ '/group-A|message-d1/',
+ '/group-A|message-e1/',
+ '/group-A|message-z1/',
+ '/group-B|message-c1/',
+ '/group-B|message-d1/',
+ '/group-B|message-z1/',
+ '/group-D|message-e1/',
+ '/message-a1|group-B/',
+ '/message-b1|group-C/',
+ '/message-d1|group-E/',
+
+ 'queryWithoutMatches',
+ ''
+ ];
+
+ for (var testcase of testcases)
+ setFilterAndDumpMessages(testcase);
+ InspectorTest.completeTest();
+
+ /**
+ * @param {string} query
+ */
+ function setFilterAndDumpMessages(query) {
+ if (query)
+ InspectorTest.addResult("\nFilter set to: " + query + "\n");
+ else
+ InspectorTest.addResult("\nFilter cleared\n");
+
+ Console.ConsoleView.instance()._filter._textFilterUI.setValue(query);
+ Console.ConsoleView.instance()._filter._textFilterChanged();
+ var messages = Console.ConsoleView.instance()._visibleViewMessages;
+ if (messages.length < 1)
+ InspectorTest.addResult("No messages to show.");
+ for (var i = 0; i < messages.length; ++i) {
+ var viewMessage = messages[i];
+ var delimeter = viewMessage.consoleMessage().isGroupStartMessage() ? ">" : "";
chenwilliam 2017/07/20 00:22:33 nit: s/delimeter/delimiter
luoe 2017/07/20 20:59:03 Done.
+ var indent = "";
chenwilliam 2017/07/20 00:22:33 nit: var indent = " ".repeat(viewMessage.nestingLe
luoe 2017/07/20 20:59:03 Done.
+ for (var j = 0; j < viewMessage.nestingLevel(); ++j)
+ indent += " ";
+ InspectorTest.addResult(indent + delimeter + viewMessage.toMessageElement().deepTextContent());
+ }
+ }
+}
+
+</script>
+</head>
+
+<body onload="runTest()">
+<p>
+ Tests that console can filter messages in groups appropriately.
+</p>
+
+</body>
+</html>
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/inspector/console/console-filter-groups-expected.txt » ('j') | third_party/WebKit/LayoutTests/inspector/console/console-filter-groups-expected.txt » ('J')

Powered by Google App Engine
This is Rietveld 408576698