Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Unified Diff: extensions/common/extensions_client.h

Issue 293943002: Clean up TestFeaturesNativeHandler to use the ExtensionsClient's JSON feature sources. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/common/extension_api.cc ('k') | extensions/common/features/base_feature_provider_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/common/extensions_client.h
diff --git a/extensions/common/extensions_client.h b/extensions/common/extensions_client.h
index b3e98929a3355ec727d473e303a40bf54601c5b1..f0bdc8c4caee61bc4427d08086ae1cca38307b2e 100644
--- a/extensions/common/extensions_client.h
+++ b/extensions/common/extensions_client.h
@@ -19,6 +19,7 @@ namespace extensions {
class APIPermissionSet;
class Extension;
class FeatureProvider;
+class JSONFeatureProviderSource;
class ManifestPermissionSet;
class PermissionMessage;
class PermissionMessageProvider;
@@ -47,6 +48,13 @@ class ExtensionsClient {
virtual scoped_ptr<FeatureProvider> CreateFeatureProvider(
const std::string& name) const = 0;
+ // Create a JSONFeatureProviderSource for a specific feature type,
+ // e.g. "permission". Currently, all features are loaded from
+ // JSONFeatureProviderSources.
+ // This is used primarily in CreateFeatureProvider, above.
+ virtual scoped_ptr<JSONFeatureProviderSource> CreateFeatureProviderSource(
+ const std::string& name) const = 0;
+
// Takes the list of all hosts and filters out those with special
// permission strings. Adds the regular hosts to |new_hosts|,
// and adds the special permission messages to |messages|.
« no previous file with comments | « extensions/common/extension_api.cc ('k') | extensions/common/features/base_feature_provider_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698