chrome/browser/bookmarks/enhanced_bookmarks_features.cc - Issue 293943002: Clean up TestFeaturesNativeHandler to use the ExtensionsClient's JSON feature sources.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/bookmarks/enhanced_bookmarks_features.cc

Issue 293943002: Clean up TestFeaturesNativeHandler to use the ExtensionsClient's JSON feature sources. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/bookmarks/enhanced_bookmarks_features.cc

diff --git a/chrome/browser/bookmarks/enhanced_bookmarks_features.cc b/chrome/browser/bookmarks/enhanced_bookmarks_features.cc

index 5ce9b9aefa09d514ad487f7d910f1034f633b698..e8ac69b1f5cfb37205660cf3bb7795d49b16630e 100644

--- a/chrome/browser/bookmarks/enhanced_bookmarks_features.cc

+++ b/chrome/browser/bookmarks/enhanced_bookmarks_features.cc

@@ -29,7 +29,7 @@ std::string GetEnhancedBookmarksExtensionIdFromFinch() {

// Returns true if enhanced bookmarks experiment is enabled from Finch.

bool IsEnhancedBookmarksExperimentEnabledFromFinch() {

std::string ext_id = GetEnhancedBookmarksExtensionIdFromFinch();

- extensions::FeatureProvider* feature_provider =

+ const extensions::FeatureProvider* feature_provider =

extensions::FeatureProvider::GetPermissionFeatures();

extensions::Feature* feature = feature_provider->GetFeature("metricsPrivate");

return feature && feature->IsIdInWhitelist(ext_id);

« no previous file with comments | « apps/shell/common/shell_extensions_client.cc ('k') | chrome/browser/ui/extensions/application_launch.cc » ('j') | no next file with comments »