extensions/renderer/api_definitions_natives.cc - Issue 293943002: Clean up TestFeaturesNativeHandler to use the ExtensionsClient's JSON feature sources.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/api_definitions_natives.cc

Issue 293943002: Clean up TestFeaturesNativeHandler to use the ExtensionsClient's JSON feature sources. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« extensions/common/extensions_client.h ('K') | « extensions/common/permissions/permissions_data.cc ('k') | extensions/renderer/dispatcher.cc » ('j') | extensions/test/test_extensions_client.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/renderer/api_definitions_natives.cc

diff --git a/extensions/renderer/api_definitions_natives.cc b/extensions/renderer/api_definitions_natives.cc

index c0dc6995de4dfb72957fcc4296e54536e6b3d58c..61ea7109fc282b169c8b29a2b0099afcc23c0ad7 100644

--- a/extensions/renderer/api_definitions_natives.cc

+++ b/extensions/renderer/api_definitions_natives.cc

@@ -23,7 +23,7 @@ ApiDefinitionsNatives::ApiDefinitionsNatives(Dispatcher* dispatcher,

void ApiDefinitionsNatives::GetExtensionAPIDefinitionsForTest(

const v8::FunctionCallbackInfo<v8::Value>& args) {

std::vector<std::string> apis;

- FeatureProvider* feature_provider = FeatureProvider::GetAPIFeatures();

+ const FeatureProvider* feature_provider = FeatureProvider::GetAPIFeatures();

const std::vector<std::string>& feature_names =

feature_provider->GetAllFeatureNames();

for (std::vector<std::string>::const_iterator i = feature_names.begin();