third_party/WebKit/Source/core/dom/Element.cpp - Issue 2939393002: Change ScrollIntoViewOptions::inlinePostion to inline

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/Element.cpp

Issue 2939393002: Change ScrollIntoViewOptions::inlinePostion to inline (Closed)

Patch Set: Add a todo Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/Element.cpp

diff --git a/third_party/WebKit/Source/core/dom/Element.cpp b/third_party/WebKit/Source/core/dom/Element.cpp

index 330388de3b891c2d806ea43740c1a4e2803bb2f2..467981e8cc2458027877c9765e602826fd2744aa 100644

--- a/third_party/WebKit/Source/core/dom/Element.cpp

+++ b/third_party/WebKit/Source/core/dom/Element.cpp

@@ -467,9 +467,6 @@ void Element::scrollIntoView(ScrollIntoViewOptionsOrBoolean arg) {

options.behavior() == "smooth") {

options.setBehavior("instant");

}

- } else if (arg.isNull()) {

- options.setBlock("start");

- options.setInlinePosition("nearest");

}

scrollIntoViewWithOptions(options);

}