Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Unified Diff: chromeos/printing/ppd_cache.h

Issue 2939373003: Convert PpdCache and PpdProvider to TaskScheduler. (Closed)
Patch Set: rebase Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromeos/printing/ppd_cache.h
diff --git a/chromeos/printing/ppd_cache.h b/chromeos/printing/ppd_cache.h
index ee9ba654cd4abbe6c9814de55d5bfdfa816cefa6..dfc2b6f72bd8c12f9e2889345267016bffbaf5fe 100644
--- a/chromeos/printing/ppd_cache.h
+++ b/chromeos/printing/ppd_cache.h
@@ -11,7 +11,6 @@
#include "base/callback.h"
#include "base/files/file_path.h"
#include "base/memory/ref_counted.h"
-#include "base/sequenced_task_runner.h"
#include "base/time/time.h"
#include "chromeos/chromeos_export.h"
@@ -46,9 +45,7 @@ class CHROMEOS_EXPORT PpdCache : public base::RefCounted<PpdCache> {
// Create and return a Ppdcache that uses cache_dir to store state. If
// cache_base_dir does not exist, it will be lazily created the first time the
// cache needs to store state.
- static scoped_refptr<PpdCache> Create(
- const base::FilePath& cache_base_dir,
- scoped_refptr<base::SequencedTaskRunner> disk_task_runner);
+ static scoped_refptr<PpdCache> Create(const base::FilePath& cache_base_dir);
// Start a Find, looking, for an entry with the given key that is at most
// |max_age| old. |cb| will be invoked on the calling thread.
@@ -58,11 +55,7 @@ class CHROMEOS_EXPORT PpdCache : public base::RefCounted<PpdCache> {
// be invoked on completion.
virtual void Store(const std::string& key,
const std::string& contents,
- const base::Callback<void()>& cb) = 0;
-
- // Hook for testing. Returns true if all outstanding cache operations
- // are complete.
- virtual bool Idle() const = 0;
+ const base::Closure& cb) = 0;
protected:
friend class base::RefCounted<PpdCache>;

Powered by Google App Engine
This is Rietveld 408576698