Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(663)

Unified Diff: pkg/testing/lib/src/analyze.dart

Issue 2939313003: dart2js isn't strong mode clean yet. (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/analysis_options.yaml ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/testing/lib/src/analyze.dart
diff --git a/pkg/testing/lib/src/analyze.dart b/pkg/testing/lib/src/analyze.dart
index 296a023fb58389f25878366eed2a12bb1a550e31..8719df746a90c69c5b4097c9aedb69639e5db9b5 100644
--- a/pkg/testing/lib/src/analyze.dart
+++ b/pkg/testing/lib/src/analyze.dart
@@ -237,10 +237,12 @@ Future<Null> analyzeUris(
await for (AnalyzerDiagnostic diagnostic in diagnostics) {
if (diagnostic.uri != null) {
String path = toFilePath(diagnostic.uri);
- if (diagnostic.code.startsWith("STRONG_MODE") &&
+ if (!(analysisOptions?.path.contains("/pkg/compiler/") ?? false) &&
+ diagnostic.code.startsWith("STRONG_MODE") &&
(path.startsWith("pkg/compiler/") ||
path.startsWith("tests/compiler/dart2js/"))) {
- // Hack to work around dart2js not being strong-mode clean.
+ // TODO(ahe): Remove this hack to work around dart2js not being
+ // strong-mode clean.
continue;
}
if (!filesToAnalyze.contains(path)) continue;
« no previous file with comments | « pkg/compiler/analysis_options.yaml ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698