Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(889)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/resources/engagement/site_engagement.js

Issue 2939273002: DO NOT SUBMIT: what chrome/browser/resources/ could eventually look like with clang-format (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/domain_reliability_internals.js ('k') | chrome/browser/resources/extensions/chromeos/kiosk_app_disable_bailout_confirm.js » ('j') | chrome/browser/resources/settings/device_page/stylus.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/engagement/site_engagement.js
diff --git a/chrome/browser/resources/engagement/site_engagement.js b/chrome/browser/resources/engagement/site_engagement.js
index ae922dfe4df0d956904e844f4137f5a5469a3fb1..c70ff186eec17b24d2b289f1b2818f5c03801b8a 100644
--- a/chrome/browser/resources/engagement/site_engagement.js
+++ b/chrome/browser/resources/engagement/site_engagement.js
@@ -15,201 +15,209 @@ function whenPageIsPopulatedForTest() {
return pageIsPopulatedPromise;
}
-define('main', [
- 'chrome/browser/engagement/site_engagement_details.mojom',
- 'content/public/renderer/frame_interfaces',
-], (siteEngagementMojom, frameInterfaces) => {
- return () => {
- var uiHandler = new siteEngagementMojom.SiteEngagementDetailsProviderPtr(
- frameInterfaces.getInterface(
- siteEngagementMojom.SiteEngagementDetailsProvider.name));
-
- var engagementTableBody = $('engagement-table-body');
- var updateInterval = null;
- var info = null;
- var sortKey = 'total_score';
- var sortReverse = true;
-
- // Set table header sort handlers.
- var engagementTableHeader = $('engagement-table-header');
- var headers = engagementTableHeader.children;
- for (var i = 0; i < headers.length; i++) {
- headers[i].addEventListener('click', (e) => {
- var newSortKey = e.target.getAttribute('sort-key');
- if (sortKey == newSortKey) {
- sortReverse = !sortReverse;
- } else {
- sortKey = newSortKey;
- sortReverse = false;
+define(
+ 'main',
+ [
+ 'chrome/browser/engagement/site_engagement_details.mojom',
+ 'content/public/renderer/frame_interfaces',
+ ],
+ (siteEngagementMojom, frameInterfaces) => {
+ return () => {
+ var uiHandler =
+ new siteEngagementMojom.SiteEngagementDetailsProviderPtr(
+ frameInterfaces.getInterface(
+ siteEngagementMojom.SiteEngagementDetailsProvider.name));
+
+ var engagementTableBody = $('engagement-table-body');
+ var updateInterval = null;
+ var info = null;
+ var sortKey = 'total_score';
+ var sortReverse = true;
+
+ // Set table header sort handlers.
+ var engagementTableHeader = $('engagement-table-header');
+ var headers = engagementTableHeader.children;
+ for (var i = 0; i < headers.length; i++) {
+ headers[i].addEventListener('click', (e) => {
+ var newSortKey = e.target.getAttribute('sort-key');
+ if (sortKey == newSortKey) {
+ sortReverse = !sortReverse;
+ } else {
+ sortKey = newSortKey;
+ sortReverse = false;
+ }
+ var oldSortColumn = document.querySelector('.sort-column');
+ oldSortColumn.classList.remove('sort-column');
+ e.target.classList.add('sort-column');
+ if (sortReverse)
+ e.target.setAttribute('sort-reverse', '');
+ else
+ e.target.removeAttribute('sort-reverse');
+ renderTable();
+ });
}
- var oldSortColumn = document.querySelector('.sort-column');
- oldSortColumn.classList.remove('sort-column');
- e.target.classList.add('sort-column');
- if (sortReverse)
- e.target.setAttribute('sort-reverse', '');
- else
- e.target.removeAttribute('sort-reverse');
- renderTable();
- });
- }
-
- /**
- * Creates a single row in the engagement table.
- * @param {SiteEngagementDetails} info The info to create the row from.
- * @return {HTMLElement}
- */
- function createRow(info) {
- var originCell = createElementWithClassName('td', 'origin-cell');
- originCell.textContent = info.origin.url;
-
- var baseScoreInput = createElementWithClassName('input',
- 'base-score-input');
- baseScoreInput.addEventListener(
- 'change', handleBaseScoreChange.bind(undefined, info.origin));
- baseScoreInput.addEventListener('focus', disableAutoupdate);
- baseScoreInput.addEventListener('blur', enableAutoupdate);
- baseScoreInput.value = info.base_score;
-
- var baseScoreCell = createElementWithClassName('td', 'base-score-cell');
- baseScoreCell.appendChild(baseScoreInput);
-
- var bonusScoreCell = createElementWithClassName('td', 'bonus-score-cell');
- bonusScoreCell.textContent = info.bonus_score;
-
- var totalScoreCell = createElementWithClassName('td', 'total-score-cell');
- totalScoreCell.textContent = info.total_score;
-
- var engagementBar = createElementWithClassName('div', 'engagement-bar');
- engagementBar.style.width = (info.total_score * 4) + 'px';
-
- var engagementBarCell =
- createElementWithClassName('td', 'engagement-bar-cell');
- engagementBarCell.appendChild(engagementBar);
-
- var row = document.createElement('tr');
- row.appendChild(originCell);
- row.appendChild(baseScoreCell);
- row.appendChild(bonusScoreCell);
- row.appendChild(totalScoreCell);
- row.appendChild(engagementBarCell);
-
- // Stores correspondent engagementBarCell to change it's length on
- // scoreChange event.
- baseScoreInput.barCellRef = engagementBar;
- return row;
- }
-
- function disableAutoupdate() {
- if (updateInterval)
- clearInterval(updateInterval);
- updateInterval = null;
- }
-
- function enableAutoupdate() {
- if (updateInterval)
- clearInterval(updateInterval);
- updateInterval = setInterval(updateEngagementTable, 5000);
- }
-
- /**
- * Sets the base engagement score when a score input is changed.
- * Resets the length of engagement-bar-cell to match the new score.
- * Also resets the update interval.
- * @param {string} origin The origin of the engagement score to set.
- * @param {Event} e
- */
- function handleBaseScoreChange(origin, e) {
- var baseScoreInput = e.target;
- uiHandler.setSiteEngagementBaseScoreForUrl(origin, baseScoreInput.value);
- baseScoreInput.barCellRef.style.width = (baseScoreInput.value * 4) + 'px';
- baseScoreInput.blur();
- enableAutoupdate();
- }
-
- /**
- * Remove all rows from the engagement table.
- */
- function clearTable() {
- engagementTableBody.innerHTML = '';
- }
-
- /**
- * Sort the engagement info based on |sortKey| and |sortReverse|.
- */
- function sortInfo() {
- info.sort((a, b) => {
- return (sortReverse ? -1 : 1) *
- compareTableItem(sortKey, a, b);
- });
- }
-
- /**
- * Compares two SiteEngagementDetails objects based on |sortKey|.
- * @param {string} sortKey The name of the property to sort by.
- * @return {number} A negative number if |a| should be ordered before |b|, a
- * positive number otherwise.
- */
- function compareTableItem(sortKey, a, b) {
- var val1 = a[sortKey];
- var val2 = b[sortKey];
-
- // Compare the hosts of the origin ignoring schemes.
- if (sortKey == 'origin')
- return new URL(val1.url).host > new URL(val2.url).host ? 1 : -1;
-
- if (sortKey == 'base_score' ||
- sortKey == 'bonus_score' ||
- sortKey == 'total_score') {
- return val1 - val2;
- }
-
- assertNotReached('Unsupported sort key: ' + sortKey);
- return 0;
- }
-
- /**
- * Rounds the supplied value to two decimal places of accuracy.
- * @param {number} score
- * @return {number}
- */
- function roundScore(score) {
- return Number(Math.round(score * 100) / 100);
- }
-
- /**
- * Regenerates the engagement table from |info|.
- */
- function renderTable() {
- clearTable();
- sortInfo();
-
- info.forEach((info) => {
- // Round all scores to 2 decimal places.
- info.base_score = roundScore(info.base_score);
- info.installed_bonus = roundScore(info.installed_bonus);
- info.notifications_bonus = roundScore(info.notifications_bonus);
- info.total_score = roundScore(info.total_score);
-
- // Collate the bonuses into a value for the bonus_score column.
- info.bonus_score = info.installed_bonus + info.notifications_bonus;
-
- engagementTableBody.appendChild(createRow(info));
- });
- }
-
- /**
- * Retrieve site engagement info and render the engagement table.
- */
- function updateEngagementTable() {
- // Populate engagement table.
- uiHandler.getSiteEngagementDetails().then((response) => {
- info = response.info;
- renderTable(info);
- resolvePageIsPopulated();
- });
- }
-
- updateEngagementTable();
- enableAutoupdate();
- };
-});
+
+ /**
+ * Creates a single row in the engagement table.
+ * @param {SiteEngagementDetails} info The info to create the row from.
+ * @return {HTMLElement}
+ */
+ function createRow(info) {
+ var originCell = createElementWithClassName('td', 'origin-cell');
+ originCell.textContent = info.origin.url;
+
+ var baseScoreInput =
+ createElementWithClassName('input', 'base-score-input');
+ baseScoreInput.addEventListener(
+ 'change', handleBaseScoreChange.bind(undefined, info.origin));
+ baseScoreInput.addEventListener('focus', disableAutoupdate);
+ baseScoreInput.addEventListener('blur', enableAutoupdate);
+ baseScoreInput.value = info.base_score;
+
+ var baseScoreCell =
+ createElementWithClassName('td', 'base-score-cell');
+ baseScoreCell.appendChild(baseScoreInput);
+
+ var bonusScoreCell =
+ createElementWithClassName('td', 'bonus-score-cell');
+ bonusScoreCell.textContent = info.bonus_score;
+
+ var totalScoreCell =
+ createElementWithClassName('td', 'total-score-cell');
+ totalScoreCell.textContent = info.total_score;
+
+ var engagementBar =
+ createElementWithClassName('div', 'engagement-bar');
+ engagementBar.style.width = (info.total_score * 4) + 'px';
+
+ var engagementBarCell =
+ createElementWithClassName('td', 'engagement-bar-cell');
+ engagementBarCell.appendChild(engagementBar);
+
+ var row = document.createElement('tr');
+ row.appendChild(originCell);
+ row.appendChild(baseScoreCell);
+ row.appendChild(bonusScoreCell);
+ row.appendChild(totalScoreCell);
+ row.appendChild(engagementBarCell);
+
+ // Stores correspondent engagementBarCell to change it's length on
+ // scoreChange event.
+ baseScoreInput.barCellRef = engagementBar;
+ return row;
+ }
+
+ function disableAutoupdate() {
+ if (updateInterval)
+ clearInterval(updateInterval);
+ updateInterval = null;
+ }
+
+ function enableAutoupdate() {
+ if (updateInterval)
+ clearInterval(updateInterval);
+ updateInterval = setInterval(updateEngagementTable, 5000);
+ }
+
+ /**
+ * Sets the base engagement score when a score input is changed.
+ * Resets the length of engagement-bar-cell to match the new score.
+ * Also resets the update interval.
+ * @param {string} origin The origin of the engagement score to set.
+ * @param {Event} e
+ */
+ function handleBaseScoreChange(origin, e) {
+ var baseScoreInput = e.target;
+ uiHandler.setSiteEngagementBaseScoreForUrl(
+ origin, baseScoreInput.value);
+ baseScoreInput.barCellRef.style.width =
+ (baseScoreInput.value * 4) + 'px';
+ baseScoreInput.blur();
+ enableAutoupdate();
+ }
+
+ /**
+ * Remove all rows from the engagement table.
+ */
+ function clearTable() {
+ engagementTableBody.innerHTML = '';
+ }
+
+ /**
+ * Sort the engagement info based on |sortKey| and |sortReverse|.
+ */
+ function sortInfo() {
+ info.sort((a, b) => {
+ return (sortReverse ? -1 : 1) * compareTableItem(sortKey, a, b);
+ });
+ }
+
+ /**
+ * Compares two SiteEngagementDetails objects based on |sortKey|.
+ * @param {string} sortKey The name of the property to sort by.
+ * @return {number} A negative number if |a| should be ordered before |b|, a
+ * positive number otherwise.
+ */
+ function compareTableItem(sortKey, a, b) {
+ var val1 = a[sortKey];
+ var val2 = b[sortKey];
+
+ // Compare the hosts of the origin ignoring schemes.
+ if (sortKey == 'origin')
+ return new URL(val1.url).host > new URL(val2.url).host ? 1 : -1;
+
+ if (sortKey == 'base_score' || sortKey == 'bonus_score' ||
+ sortKey == 'total_score') {
+ return val1 - val2;
+ }
+
+ assertNotReached('Unsupported sort key: ' + sortKey);
+ return 0;
+ }
+
+ /**
+ * Rounds the supplied value to two decimal places of accuracy.
+ * @param {number} score
+ * @return {number}
+ */
+ function roundScore(score) {
+ return Number(Math.round(score * 100) / 100);
+ }
+
+ /**
+ * Regenerates the engagement table from |info|.
+ */
+ function renderTable() {
+ clearTable();
+ sortInfo();
+
+ info.forEach((info) => {
+ // Round all scores to 2 decimal places.
+ info.base_score = roundScore(info.base_score);
+ info.installed_bonus = roundScore(info.installed_bonus);
+ info.notifications_bonus = roundScore(info.notifications_bonus);
+ info.total_score = roundScore(info.total_score);
+
+ // Collate the bonuses into a value for the bonus_score column.
+ info.bonus_score = info.installed_bonus + info.notifications_bonus;
+
+ engagementTableBody.appendChild(createRow(info));
+ });
+ }
+
+ /**
+ * Retrieve site engagement info and render the engagement table.
+ */
+ function updateEngagementTable() {
+ // Populate engagement table.
+ uiHandler.getSiteEngagementDetails().then((response) => {
+ info = response.info;
+ renderTable(info);
+ resolvePageIsPopulated();
+ });
+ }
+
+ updateEngagementTable();
+ enableAutoupdate();
+ };
+ });
« no previous file with comments | « chrome/browser/resources/domain_reliability_internals.js ('k') | chrome/browser/resources/extensions/chromeos/kiosk_app_disable_bailout_confirm.js » ('j') | chrome/browser/resources/settings/device_page/stylus.js » ('J')

Powered by Google App Engine
This is Rietveld 408576698