Add a test that verifies that the active WebContents is shown

chrome/browser/ui/views/frame/browser_view_browsertest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/frame/browser_view.h"
 
 #include "base/prefs/pref_service.h"
 #include "chrome/browser/devtools/devtools_window_testing.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_tabstrip.h"
 #include "chrome/browser/ui/tabs/tab_strip_model.h"
 #include "chrome/browser/ui/views/bookmarks/bookmark_bar_view.h"
 #include "chrome/browser/ui/views/bookmarks/bookmark_bar_view_observer.h"
 #include "chrome/common/url_constants.h"
 #include "chrome/test/base/in_process_browser_test.h"
 #include "chrome/test/base/ui_test_utils.h"
 #include "components/bookmarks/common/bookmark_pref_names.h"
 #include "content/public/browser/invalidate_type.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/browser/web_contents_observer.h"
+#include "ui/base/ui_base_types.h"
 
 class BrowserViewTest : public InProcessBrowserTest {
  public:
   BrowserViewTest() : InProcessBrowserTest(), devtools_(nullptr) {}
 
  protected:
   BrowserView* browser_view() {
     return BrowserView::GetBrowserViewForBrowser(browser());
   }
 
@@ skipping 40 matching lines @@
     other_->NotifyNavigationStateChanged(static_cast<content::InvalidateTypes>(
         content::INVALIDATE_TYPE_URL | content::INVALIDATE_TYPE_LOAD));
   }
 
  private:
   content::WebContents* other_;
 
   DISALLOW_COPY_AND_ASSIGN(TestWebContentsObserver);
 };
 
+class WebContentsShowHideObserver : public content::WebContentsObserver {
+ public:
+  WebContentsShowHideObserver(content::WebContents* web_contents,
+                              const base::Closure& callback)
+      : WebContentsObserver(web_contents),
+        callback_(callback),
+        show_state_(ui::SHOW_STATE_DEFAULT) {}
+
+  // WebContentsObserver.
+  virtual void WasHidden() override {
+    show_state_ = ui::SHOW_STATE_INACTIVE;
+    callback_.Run();
+  }
+
+  virtual void WasShown() override {
+    show_state_ = ui::SHOW_STATE_NORMAL;
+    callback_.Run();
+  }
+
+  bool shown() { return show_state_ == ui::SHOW_STATE_NORMAL; }
+  bool hidden() { return show_state_ == ui::SHOW_STATE_INACTIVE; }
+
+ private:
+  base::Closure callback_;
+  ui::WindowShowState show_state_;
+
+  DISALLOW_COPY_AND_ASSIGN(WebContentsShowHideObserver);
+};
+
 }  // namespace
 
 // Verifies don't crash when CloseNow() is invoked with two tabs in a browser.
 // Additionally when one of the tabs is destroyed NotifyNavigationStateChanged()
 // is invoked on the other.
 IN_PROC_BROWSER_TEST_F(BrowserViewTest, CloseWithTabs) {
   Browser* browser2 =
       new Browser(Browser::CreateParams(browser()->profile(),
                                         browser()->host_desktop_type()));
   chrome::AddTabAt(browser2, GURL(), -1, true);
@@ skipping 139 matching lines @@
   EXPECT_EQ(0, observer.change_count());
   observer.clear_change_count();
 
   browser()->tab_strip_model()->ActivateTabAt(1, true);
   EXPECT_TRUE(bookmark_bar->visible());
   EXPECT_EQ(0, observer.change_count());
   observer.clear_change_count();
 
   browser_view()->bookmark_bar()->RemoveObserver(&observer);
 }
+
+IN_PROC_BROWSER_TEST_F(BrowserViewTest, MinimizeHidesWebContents) {
+  // Minimizing the window should cause the active WebContents to be hidden.
+  {
+    base::RunLoop run_loop;
+    WebContentsShowHideObserver observed(
+        browser()->tab_strip_model()->GetActiveWebContents(),
+        run_loop.QuitClosure());
+
+    ASSERT_FALSE(observed.hidden());
+    ASSERT_FALSE(observed.shown());
+    browser()->window()->Minimize();
+    if (!observed.hidden())
+      run_loop.Run();
+    ASSERT_TRUE(observed.hidden());
+    ASSERT_FALSE(observed.shown());
+  }
+
+  // Restoring the window should cause the active WebContents to be shown.
+  {
+    base::RunLoop run_loop;
+    WebContentsShowHideObserver observed(
+        browser()->tab_strip_model()->GetActiveWebContents(),
+        run_loop.QuitClosure());
+
+    ASSERT_FALSE(observed.hidden());
+    ASSERT_FALSE(observed.shown());
+    browser()->window()->Restore();
+    if (!observed.shown())
+      run_loop.Run();
+    ASSERT_TRUE(observed.shown());
+    ASSERT_FALSE(observed.hidden());
+  }
+}