tests/compiler/dart2js/analyze_helper.dart - Issue 2939063002: Strong mode cleaning of many dart2js tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/compiler/dart2js/analyze_helper.dart

Issue 2939063002: Strong mode cleaning of many dart2js tests. (Closed)

Patch Set: Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tests/compiler/dart2js/analyze_dart2js_helpers_test.dart ('k') | tests/compiler/dart2js/bad_output_io_test.dart » ('j') | tests/compiler/dart2js/call_site_simple_type_inferer_test.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tests/compiler/dart2js/analyze_helper.dart

diff --git a/tests/compiler/dart2js/analyze_helper.dart b/tests/compiler/dart2js/analyze_helper.dart

index 779f389a547892c8f086793b9d83e5c0d711fa34..6c83521dcde9b57068feda151b1e0d2ac13d262d 100644

--- a/tests/compiler/dart2js/analyze_helper.dart

+++ b/tests/compiler/dart2js/analyze_helper.dart

@@ -39,18 +39,19 @@ class CollectingDiagnosticHandler extends FormattingDiagnosticHandler {

bool lastWasWhitelisted = false;

bool showWhitelisted = true;

- Map<String, Map<dynamic /*String|MessageKind*/, int>> whiteListMap =

- new Map<String, Map<dynamic /*String|MessageKind*/, int>>();

+ Map<String, Map<dynamic /* String|MessageKind */, int>> whiteListMap =

Emily Fortuna 2017/06/15 18:33:10 who knew strong mode had whitespacing preferences?

ahe 2017/06/16 07:26:46 These whitespace changes are important :-O See ht

+ new Map<String, Map<dynamic /* String|MessageKind */, int>>();

List<MessageKind> skipList;

List<CollectedMessage> collectedMessages = <CollectedMessage>[];

CollectingDiagnosticHandler(

- Map<String, List/*<String|MessageKind>*/ > whiteList,

+ Map<String, List /* <String|MessageKind> */ > whiteList,

this.skipList,

SourceFileProvider provider)

: super(provider) {

- whiteList.forEach((String file, List/*<String|MessageKind>*/ messageParts) {

- var useMap = new Map<dynamic /*String|MessageKind*/, int>();

+ whiteList

+ .forEach((String file, List /* <String|MessageKind> */ messageParts) {

+ var useMap = new Map<dynamic /* String|MessageKind */, int>();

for (var messagePart in messageParts) {

useMap[messagePart] = 0;

}

@@ -202,7 +203,7 @@ enum AnalysisMode {

/// Messages can be generally allowed using [skipList] or on a per-file basis

/// using [whiteList].

Future analyze(

- List<Uri> uriList, Map<String, List/*<String|MessageKind>*/ > whiteList,

+ List<Uri> uriList, Map<String, List /* <String|MessageKind> */ > whiteList,

{AnalysisMode mode: AnalysisMode.ALL,

CheckResults checkResults,

List<String> options: const <String>[],