pkg/kernel/lib/transformations/closure/converter.dart - Issue 2939043002: Remove unnecessary contexts in closure conversion

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/kernel/lib/transformations/closure/converter.dart

Issue 2939043002: Remove unnecessary contexts in closure conversion (Closed)

Patch Set: Don't treat constructor parameters in initializers as captured Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/kernel/lib/transformations/closure/converter.dart

diff --git a/pkg/kernel/lib/transformations/closure/converter.dart b/pkg/kernel/lib/transformations/closure/converter.dart

index ecf7efbd8e1c4cf59dfb0a3d6160356678d8f93f..410386f18f72f3d70e8d15bac2cb5d6734074f02 100644

--- a/pkg/kernel/lib/transformations/closure/converter.dart

+++ b/pkg/kernel/lib/transformations/closure/converter.dart

@@ -416,7 +416,7 @@ class ClosureConverter extends Transformer {

// We rename the getter to avoid an indirection in most cases.

Name oldName = node.name;

node.name = tearOffName;

- node.reference.canonicalName.unbind();

+ node.canonicalName?.unbind();

addGetterForwarder(oldName, node);

} else if (node.kind == ProcedureKind.Method) {

addTearOffMethod(tearOffName, node);