Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(98)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: pkg/kernel/testcases/closures/contexts_in_field_initializers.dart
Issue
2939043002
:
Remove unnecessary contexts in closure conversion (Closed)
Patch Set: Small comment edit
Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
pkg/kernel/lib/transformations/closure/converter.dart
pkg/kernel/lib/transformations/closure/info.dart
pkg/kernel/testcases/closures/closure_in_constructor.dart.expect
pkg/kernel/testcases/closures/contexts_in_field_initializers.dart
pkg/kernel/testcases/closures/contexts_in_field_initializers.dart.expect
pkg/kernel/testcases/closures/contexts_in_super_initializers.dart
pkg/kernel/testcases/closures/contexts_in_super_initializers.dart.expect
View unified diff
|
Download patch
« no previous file with comments
|
« pkg/kernel/testcases/closures/closure_in_constructor.dart.expect
('k') |
pkg/kernel/testcases/closures/contexts_in_field_initializers.dart.expect »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
// Copyright (c) 2017, the Dart project authors. Please see the AUTHORS file
2
// for details. All rights reserved. Use of this source code is governed by a
3
// BSD-style license that can be found in the LICENSE file.
4
5
// The purpose of this test is to detect that no unnecessary contexts are
6
// created when a constructor parameter is used in its field initializers. No
7
// contexts should be created either in the initializer or in the constructor
8
// body.
9
10
class X {}
11
12
class A {
13
X x;
14
A(this.x) {}
15
}
16
17
main() {
18
A a = new A(new X());
19
}
OLD
NEW
« no previous file with comments
|
« pkg/kernel/testcases/closures/closure_in_constructor.dart.expect
('k') |
pkg/kernel/testcases/closures/contexts_in_field_initializers.dart.expect »
('j') |
no next file with comments »
Issue 2939043002: Remove unnecessary contexts in closure conversion (Closed)
Created 3 years, 6 months ago by Dmitry Stefantsov
Modified 3 years, 6 months ago
Reviewers: ahe, karlklose
Base URL:
Comments: 11
This is Rietveld
408576698