DescriptionFix runtime/tools/bin_to_assembly.py not setting symbol type and size.
The absence of symbol sizes broke build comparison that looks for and
ignores snapshots. Add symbol types for good measure to match the compiler
behavior.
Consider unknown operating systems to use as(1)-style assembly, which is
generally true. If an unknown operating system uses another syntax, the
generated files will fail to assemble and the porter should soon find
this script and add support for their operating system.
R=whesse@google.com
Committed: https://github.com/dart-lang/sdk/commit/742822af7354123610846829a3dde5bb20c2bc22
Patch Set 1 #
Messages
Total messages: 4 (1 generated)
|