Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Issue 2939013002: Fix runtime/tools/bin_to_assembly.py not setting symbol type and size. (Closed)

Created:
3 years, 6 months ago by sortie
Modified:
3 years, 6 months ago
Reviewers:
Bill Hesse
CC:
reviews_dartlang.org, vm-dev_dartlang.org, rmacnak
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix runtime/tools/bin_to_assembly.py not setting symbol type and size. The absence of symbol sizes broke build comparison that looks for and ignores snapshots. Add symbol types for good measure to match the compiler behavior. Consider unknown operating systems to use as(1)-style assembly, which is generally true. If an unknown operating system uses another syntax, the generated files will fail to assemble and the porter should soon find this script and add support for their operating system. R=whesse@google.com Committed: https://github.com/dart-lang/sdk/commit/742822af7354123610846829a3dde5bb20c2bc22

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -10 lines) Patch
M runtime/tools/bin_to_assembly.py View 3 chunks +12 lines, -10 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
sortie
3 years, 6 months ago (2017-06-15 10:38:53 UTC) #1
Bill Hesse
lgtm
3 years, 6 months ago (2017-06-15 11:39:14 UTC) #2
sortie
3 years, 6 months ago (2017-06-15 11:41:12 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
742822af7354123610846829a3dde5bb20c2bc22 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698