third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIBorderRadius.cpp - Issue 2938983002: Implement parseShorthand API for shorthand properties, "overflow", "font" and "font-variant"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIBorderRadius.cpp

Issue 2938983002: Implement parseShorthand API for shorthand properties, "overflow", "font" and "font-variant" (Closed)

Patch Set: Change AddProperty's "implicit" to an enum. Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.h ('K') | « third_party/WebKit/Source/core/css/properties/CSSPropertyFontUtils.cpp ('k') | third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIFlex.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIBorderRadius.cpp

diff --git a/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIBorderRadius.cpp b/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIBorderRadius.cpp

index d1ca80ce3e0bec3141385284026074dcf059bd25..5225afe1bd7806b96d590cd7da52b27923517cbf 100644

--- a/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIBorderRadius.cpp

+++ b/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIBorderRadius.cpp

@@ -30,22 +30,22 @@ bool CSSShorthandPropertyAPIBorderRadius::parseShorthand(

CSSPropertyBorderTopLeftRadius, CSSPropertyBorderRadius,

*CSSValuePair::Create(horizontal_radii[0], vertical_radii[0],

CSSValuePair::kDropIdenticalValues),

- important, false /* implicit */, properties);

+ important, CSSPropertyParserHelpers::kNotImplicit, properties);

CSSPropertyParserHelpers::AddProperty(

CSSPropertyBorderTopRightRadius, CSSPropertyBorderRadius,

*CSSValuePair::Create(horizontal_radii[1], vertical_radii[1],

CSSValuePair::kDropIdenticalValues),

- important, false /* implicit */, properties);

+ important, CSSPropertyParserHelpers::kNotImplicit, properties);

CSSPropertyParserHelpers::AddProperty(

CSSPropertyBorderBottomRightRadius, CSSPropertyBorderRadius,

*CSSValuePair::Create(horizontal_radii[2], vertical_radii[2],

CSSValuePair::kDropIdenticalValues),

- important, false /* implicit */, properties);

+ important, CSSPropertyParserHelpers::kNotImplicit, properties);

CSSPropertyParserHelpers::AddProperty(

CSSPropertyBorderBottomLeftRadius, CSSPropertyBorderRadius,

*CSSValuePair::Create(horizontal_radii[3], vertical_radii[3],

CSSValuePair::kDropIdenticalValues),

- important, false /* implicit */, properties);

+ important, CSSPropertyParserHelpers::kNotImplicit, properties);

return true;

}