Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Unified Diff: third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.h

Issue 2938983002: Implement parseShorthand API for shorthand properties, "overflow", "font" and "font-variant" (Closed)
Patch Set: Change AddProperty's "implicit" to an enum. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.h
diff --git a/third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.h b/third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.h
index fe5e17adbb5dfece85455150ad6138364dc24b25..924c226877696baa8969ff3f68e46ce65fcc9768 100644
--- a/third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.h
+++ b/third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.h
@@ -111,11 +111,13 @@ bool IsCSSWideKeyword(StringView);
CSSIdentifierValue* ConsumeShapeBox(CSSParserTokenRange&);
+enum ImplicitProperty { kNotImplicit, kImplicit };
Bugs Nash 2017/06/19 23:30:12 nit: enum class is safer as it's type safe. especi
Jia 2017/06/20 01:05:51 I've changed it to enum class. However, I think Im
+
void AddProperty(CSSPropertyID resolved_property,
CSSPropertyID current_shorthand,
const CSSValue&,
bool important,
- bool implicit,
+ ImplicitProperty,
HeapVector<CSSProperty, 256>& properties);
// Template implementations are at the bottom of the file for readability.

Powered by Google App Engine
This is Rietveld 408576698