third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIFlex.cpp - Issue 2938983002: Implement parseShorthand API for shorthand properties, "overflow", "font" and "font-variant"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIFlex.cpp

Issue 2938983002: Implement parseShorthand API for shorthand properties, "overflow", "font" and "font-variant" (Closed)

Patch Set: Replace ImplicitProperty by IsImplicitProperty Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIBorderRadius.cpp ('k') | third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIFont.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIFlex.cpp

diff --git a/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIFlex.cpp b/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIFlex.cpp

index 954b9462fd8fec6459a92d95b055fe6abaed48c3..dec409144c60ab44423235ea5962e680281eee8f 100644

--- a/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIFlex.cpp

+++ b/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIFlex.cpp

@@ -76,16 +76,18 @@ bool CSSShorthandPropertyAPIFlex::parseShorthand(

CSSPropertyFlexGrow, CSSPropertyFlex,

*CSSPrimitiveValue::Create(clampTo<float>(flex_grow),

CSSPrimitiveValue::UnitType::kNumber),

- important, false /* implicit */, properties);

+ important, CSSPropertyParserHelpers::IsImplicitProperty::kNotImplicit,

+ properties);

CSSPropertyParserHelpers::AddProperty(

CSSPropertyFlexShrink, CSSPropertyFlex,

*CSSPrimitiveValue::Create(clampTo<float>(flex_shrink),

CSSPrimitiveValue::UnitType::kNumber),

- important, false /* implicit */, properties);

+ important, CSSPropertyParserHelpers::IsImplicitProperty::kNotImplicit,

+ properties);

- CSSPropertyParserHelpers::AddProperty(CSSPropertyFlexBasis, CSSPropertyFlex,

- *flex_basis, important,

- false /* implicit */, properties);

+ CSSPropertyParserHelpers::AddProperty(

+ CSSPropertyFlexBasis, CSSPropertyFlex, *flex_basis, important,

+ CSSPropertyParserHelpers::IsImplicitProperty::kNotImplicit, properties);

return true;

}