Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Unified Diff: third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.cpp

Issue 2938983002: Implement parseShorthand API for shorthand properties, "overflow", "font" and "font-variant" (Closed)
Patch Set: Replace ImplicitProperty by IsImplicitProperty Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.cpp
diff --git a/third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.cpp b/third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.cpp
index 524e3439f3b84f2d5cc129ca5e6409ddb169307d..481166078bf93363deb0617ae63018ac0e35e734 100644
--- a/third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.cpp
+++ b/third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.cpp
@@ -1461,9 +1461,11 @@ void AddProperty(CSSPropertyID resolved_property,
CSSPropertyID current_shorthand,
const CSSValue& value,
bool important,
- bool implicit,
+ IsImplicitProperty implicit,
HeapVector<CSSProperty, 256>& properties) {
DCHECK(!isPropertyAlias(resolved_property));
+ DCHECK(implicit == IsImplicitProperty::kNotImplicit ||
+ implicit == IsImplicitProperty::kImplicit);
int shorthand_index = 0;
bool set_from_shorthand = false;
@@ -1480,7 +1482,7 @@ void AddProperty(CSSPropertyID resolved_property,
properties.push_back(CSSProperty(resolved_property, value, important,
set_from_shorthand, shorthand_index,
- implicit));
+ implicit == IsImplicitProperty::kImplicit));
}
} // namespace CSSPropertyParserHelpers

Powered by Google App Engine
This is Rietveld 408576698