third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIWebkitMarginCollapse.cpp - Issue 2938983002: Implement parseShorthand API for shorthand properties, "overflow", "font" and "font-variant"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIWebkitMarginCollapse.cpp

Issue 2938983002: Implement parseShorthand API for shorthand properties, "overflow", "font" and "font-variant" (Closed)

Patch Set: Remove tmp file. Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.h ('K') | « third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIOverflow.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIWebkitMarginCollapse.cpp

diff --git a/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIWebkitMarginCollapse.cpp b/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIWebkitMarginCollapse.cpp

index cf22436b2d7398c2a590763bf3e02482ea477663..30a0048ec177dc5b4e14843e212b772ee277f351 100644

--- a/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIWebkitMarginCollapse.cpp

+++ b/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIWebkitMarginCollapse.cpp

@@ -25,12 +25,14 @@ bool CSSShorthandPropertyAPIWebkitMarginCollapse::parseShorthand(

CSSValue* before_collapse = CSSIdentifierValue::Create(id);

CSSPropertyParserHelpers::AddProperty(

CSSPropertyWebkitMarginBeforeCollapse, CSSPropertyWebkitMarginCollapse,

- *before_collapse, important, false /* implicit */, properties);

+ *before_collapse, important,

+ CSSPropertyParserHelpers::ImplicitProperty::kNotImplicit, properties);

if (range.AtEnd()) {

CSSPropertyParserHelpers::AddProperty(

CSSPropertyWebkitMarginAfterCollapse, CSSPropertyWebkitMarginCollapse,

- *before_collapse, important, false /* implicit */, properties);

+ *before_collapse, important,

+ CSSPropertyParserHelpers::ImplicitProperty::kNotImplicit, properties);

return true;

}

@@ -40,8 +42,8 @@ bool CSSShorthandPropertyAPIWebkitMarginCollapse::parseShorthand(

return false;

CSSPropertyParserHelpers::AddProperty(

CSSPropertyWebkitMarginAfterCollapse, CSSPropertyWebkitMarginCollapse,

- *CSSIdentifierValue::Create(id), important, false /* implicit */,

- properties);

+ *CSSIdentifierValue::Create(id), important,

+ CSSPropertyParserHelpers::ImplicitProperty::kNotImplicit, properties);

return true;

}