third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.h - Issue 2938983002: Implement parseShorthand API for shorthand properties, "overflow", "font" and "font-variant"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.h

Issue 2938983002: Implement parseShorthand API for shorthand properties, "overflow", "font" and "font-variant" (Closed)

Patch Set: Remove tmp file. Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp ('k') | third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.h

diff --git a/third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.h b/third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.h

index fe5e17adbb5dfece85455150ad6138364dc24b25..5fa146e71b83682445a00b28f82971dff20dda65 100644

--- a/third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.h

+++ b/third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.h

@@ -111,11 +111,13 @@ bool IsCSSWideKeyword(StringView);

CSSIdentifierValue* ConsumeShapeBox(CSSParserTokenRange&);

+enum class ImplicitProperty { kNotImplicit, kImplicit };

alancutter (OOO until 2018) 2017/06/20 01:50:44 Minor bikeshed: Maybe rename as IsImplicitProperty

Jia 2017/06/20 03:29:45 Done.

void AddProperty(CSSPropertyID resolved_property,

CSSPropertyID current_shorthand,

const CSSValue&,

bool important,

- bool implicit,

+ ImplicitProperty,

HeapVector<CSSProperty, 256>& properties);

// Template implementations are at the bottom of the file for readability.