Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Unified Diff: components/viz/service/hit_test/display_hit_test_data_factory.h

Issue 2938953002: Implement HitTestAggregator (Closed)
Patch Set: improvements based on reviewer comments Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/viz/service/hit_test/display_hit_test_data_factory.h
diff --git a/components/viz/service/hit_test/display_hit_test_data_factory.h b/components/viz/service/hit_test/display_hit_test_data_factory.h
new file mode 100644
index 0000000000000000000000000000000000000000..0ef918a221014f54a6c6dcba7b936c4b52a19013
--- /dev/null
+++ b/components/viz/service/hit_test/display_hit_test_data_factory.h
@@ -0,0 +1,33 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef COMPONENTS_VIZ_SERVICE_HIT_TEST_DISPLAY_HIT_TEST_DATA_FACTORY_H_
+#define COMPONENTS_VIZ_SERVICE_HIT_TEST_DISPLAY_HIT_TEST_DATA_FACTORY_H_
+
+#include <stdint.h>
+
+#include <map>
+#include <memory>
varkha 2017/06/20 19:56:58 Are 3 headers above necessary?
gklassen 2017/06/26 21:55:19 Done.
+
+#include "components/viz/common/hit_test/display_hit_test_data.h"
+#include "components/viz/service/viz_service_export.h"
varkha 2017/06/20 19:56:58 Is this necessary? Should the class be VIZ_SERVICE
gklassen 2017/06/26 21:55:19 Done.
+
+namespace viz {
+namespace hit_test {
+
+class DisplayHitTestDataFactory {
+ public:
+ virtual ~DisplayHitTestDataFactory() = default;
+
+ // Creates the memory required for a DisplayHitTestData structure.
+ // This may use an implementation that allocates local heap memory
+ // when viz and browser are in the same process and must use an
+ // implementation that allocates shared memory when they are not.
+ virtual DisplayHitTestData* Create(int byte_count) = 0;
+};
+
+} // namespace hit_test
+} // namespace viz
+
+#endif // COMPONENTS_VIZ_SERVICE_HIT_TEST_DISPLAY_HIT_TEST_DATA_FACTORY_H_
varkha 2017/06/20 19:56:58 nit: extra space after //
gklassen 2017/06/26 21:55:19 Done.

Powered by Google App Engine
This is Rietveld 408576698