components/viz/common/DEPS - Issue 2938953002: Implement HitTestAggregator

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/viz/common/DEPS

Issue 2938953002: Implement HitTestAggregator (Closed)

Patch Set: correct active count logic and add unit test to protect against similar errors Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 include_rules = [	1 include_rules = [

2 "+ui/gfx/geometry",	2 "+cc/surfaces",
	rjkroege 2017/06/30 20:10:36 I think this is too broad. Can you replace with sp I think this is too broad. Can you replace with specific .h files? danakj 2017/06/30 20:39:38 Ya I am wondering what this will be. Most of surfa Show quoted text On 2017/06/30 20:10:36, rjkroege wrote: > I think this is too broad. Can you replace with specific .h files? Ya I am wondering what this will be. Most of surfaces will be going into viz/service which this can't do. Some will be going in common tho. See https://docs.google.com/spreadsheets/d/1buIcuS-lgM1eIYChOrBEAo0BdlIkb7p1TF58L... So it would be nice to specify here. gklassen 2017/07/12 14:43:51 Done. Show quoted text On 2017/06/30 20:39:38, danakj wrote: > On 2017/06/30 20:10:36, rjkroege wrote: > > I think this is too broad. Can you replace with specific .h files? > > Ya I am wondering what this will be. Most of surfaces will be going into > viz/service which this can't do. Some will be going in common tho. See > https://docs.google.com/spreadsheets/d/1buIcuS-lgM1eIYChOrBEAo0BdlIkb7p1TF58L... > > So it would be nice to specify here. Done.
3 "+services/ui/gpu/interfaces",	3 "+services/ui/gpu/interfaces",

	4 "+services/viz/public/interfaces",
	danakj 2017/06/30 20:39:38 It seems a maybe bit off to me that viz/common wou It seems a maybe bit off to me that viz/common would include viz interfaces. The common code for use by both the client and service implementations, it feels like a level below these interfaces. But I also don't see this being used so, is it needed? gklassen 2017/07/12 14:43:51 Done. Show quoted text On 2017/06/30 20:39:38, danakj wrote: > It seems a maybe bit off to me that viz/common would include viz interfaces. The > common code for use by both the client and service implementations, it feels > like a level below these interfaces. But I also don't see this being used so, is > it needed? Done.
4 "+third_party/skia",	5 "+third_party/skia",

	6 "+ui/gfx",

5 ]	7 ]

6	8

7 specific_include_rules = {	9 specific_include_rules = {

8 ".*_unittest\.cc": [	10 ".*_unittest\.cc": [

9 "+media/base",	11 "+media/base",

10 "+ui/gfx",	12 "+ui/gfx",

11 "+ui/gl",	13 "+ui/gl",

12 ],	14 ],

13 ".*_benchmark\.cc": [	15 ".*_benchmark\.cc": [

14 "+ui/gfx",	16 "+ui/gfx",

15 ],	17 ],

16 }	18 }

OLD	NEW

« no previous file with comments | « components/viz/common/BUILD.gn ('k') | components/viz/common/display_hit_test_region.h » ('j') | components/viz/common/display_hit_test_region.h » ('J')