Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(475)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2938943003: Switch the defaults: strong mode is now default, but we stil check tests in Dart mode. (Closed)

Created:
3 years, 6 months ago by ahe
Modified:
3 years, 6 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Switch the defaults: strong mode is now default, but we stil check tests in Dart mode. R=johnniwinther@google.com Committed: https://github.com/dart-lang/sdk/commit/ba2cde4607c95c96686d2902586a23c01920308f

Patch Set 1 #

Total comments: 2

Patch Set 2 : Update status file as well. #

Patch Set 3 : Sort lines. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -227 lines) Patch
M pkg/compiler/analysis_options.yaml View 1 chunk +1 line, -1 line 0 comments Download
A + pkg/compiler/analysis_options_dart.yaml View 0 chunks +-1 lines, --1 lines 0 comments Download
D pkg/compiler/analysis_options_strong.yaml View 1 chunk +0 lines, -12 lines 0 comments Download
M pkg/compiler/testing.json View 1 2 7 chunks +35 lines, -4 lines 0 comments Download
A + pkg/compiler/testing_dart.json View 5 chunks +5 lines, -36 lines 0 comments Download
D pkg/compiler/testing_strong.json View 1 chunk +0 lines, -158 lines 0 comments Download
A + tests/compiler/dart2js/analyze_dart_test.dart View 1 chunk +1 line, -1 line 0 comments Download
D tests/compiler/dart2js/analyze_strong_test.dart View 1 chunk +0 lines, -15 lines 0 comments Download
M tests/compiler/dart2js/dart2js.status View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
ahe
3 years, 6 months ago (2017-06-15 12:05:17 UTC) #2
Johnni Winther
lgtm https://codereview.chromium.org/2938943003/diff/1/pkg/compiler/testing.json File pkg/compiler/testing.json (right): https://codereview.chromium.org/2938943003/diff/1/pkg/compiler/testing.json#newcode119 pkg/compiler/testing.json:119: "^tests/compiler/dart2js/analyze_dart2js_helpers_test\\.dart", Sort the lines ?
3 years, 6 months ago (2017-06-15 12:12:27 UTC) #3
ahe
Thank you, Johnni! https://codereview.chromium.org/2938943003/diff/1/pkg/compiler/testing.json File pkg/compiler/testing.json (right): https://codereview.chromium.org/2938943003/diff/1/pkg/compiler/testing.json#newcode119 pkg/compiler/testing.json:119: "^tests/compiler/dart2js/analyze_dart2js_helpers_test\\.dart", On 2017/06/15 12:12:27, Johnni Winther ...
3 years, 6 months ago (2017-06-15 12:15:32 UTC) #4
ahe
3 years, 6 months ago (2017-06-15 12:16:45 UTC) #6
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
ba2cde4607c95c96686d2902586a23c01920308f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698