Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Unified Diff: third_party/WebKit/LayoutTests/media/controls/controls-video-keynav.html

Issue 2938913002: Updates volume to change by .05 increments. (Closed)
Patch Set: Addresses comment 22. Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/media/controls/controls-video-keynav.html
diff --git a/third_party/WebKit/LayoutTests/media/controls/controls-video-keynav.html b/third_party/WebKit/LayoutTests/media/controls/controls-video-keynav.html
index 4c69aef15617de11a7a3f9af24e39a6da7f722b9..d142e52ce4310252ea2273e31743012e1bcd1cb5 100644
--- a/third_party/WebKit/LayoutTests/media/controls/controls-video-keynav.html
+++ b/third_party/WebKit/LayoutTests/media/controls/controls-video-keynav.html
@@ -24,11 +24,17 @@ async_test(function(t) {
eventSender.keyDown("Enter");
assert_false(video.paused);
- // 'Down' reduces volume.
+ // 'Down' reduces volume by .05.
eventSender.keyDown("ArrowDown");
- assert_less_than(video.volume, 1);
+ assert_equals(video.volume, .95);
+
+ eventSender.keyDown("ArrowDown");
+ assert_equals(video.volume, .9);
+
+ // 'Up' increases volume by .05
+ eventSender.keyDown("ArrowUp");
+ assert_equals(video.volume, .95);
- // 'Up' increases volume.
eventSender.keyDown("ArrowUp");
assert_equals(video.volume, 1);
« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698