Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Issue 2938793002: Implement metadata on classes and additional semantic checks. (Closed)

Created:
3 years, 6 months ago by ahe
Modified:
3 years, 6 months ago
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Implement metadata on classes and additional semantic checks. R=paulberry@google.com Committed: https://github.com/dart-lang/sdk/commit/6302a5b31be95dcd46150e018c3a32c68c410a5f

Patch Set 1 #

Patch Set 2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -84 lines) Patch
M pkg/analyzer/lib/src/fasta/analyzer_diet_listener.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/builder/modifier_builder.dart View 1 chunk +6 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/body_builder.dart View 1 3 chunks +67 lines, -28 lines 0 comments Download
M pkg/front_end/lib/src/fasta/source/diet_listener.dart View 2 chunks +12 lines, -3 lines 0 comments Download
M pkg/front_end/test/fasta/shaker.status View 1 chunk +0 lines, -1 line 0 comments Download
M tests/co19/co19-kernel.status View 2 chunks +2 lines, -16 lines 0 comments Download
M tests/language/language_kernel.status View 1 chunk +0 lines, -2 lines 0 comments Download
M tests/lib/lib.status View 2 chunks +5 lines, -33 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
ahe
3 years, 6 months ago (2017-06-14 10:33:54 UTC) #2
Paul Berry
lgtm
3 years, 6 months ago (2017-06-14 12:18:32 UTC) #3
ahe
3 years, 6 months ago (2017-06-14 13:00:00 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
6302a5b31be95dcd46150e018c3a32c68c410a5f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698