Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Issue 2938773003: Add transformLibraries for closure conversion (Closed)

Created:
3 years, 6 months ago by Dmitry Stefantsov
Modified:
3 years, 6 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add transformLibraries for closure conversion Closure conversion can now be run on a part of a program. It allows using closure conversion in kernel-isolate. It comes at a cost of temporarily sacrificing implementation of tear-offs via closures; VM mechanism for tear-offs is used for now. R=ahe@google.com Committed: https://github.com/dart-lang/sdk/commit/5982ace801dc4f222f3a327066d8494be3a969b3

Patch Set 1 #

Patch Set 2 : Merge-in lastest changes in master (f71e6fd49b) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -104 lines) Patch
M pkg/kernel/lib/transformations/closure/info.dart View 1 chunk +13 lines, -7 lines 0 comments Download
M pkg/kernel/lib/transformations/closure/mock.dart View 2 chunks +17 lines, -2 lines 0 comments Download
M pkg/kernel/lib/transformations/closure_conversion.dart View 2 chunks +21 lines, -3 lines 0 comments Download
M pkg/kernel/test/closures/suite.dart View 2 chunks +4 lines, -2 lines 0 comments Download
M pkg/kernel/testcases/closures/instance_tear_off.dart.expect View 5 chunks +6 lines, -90 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
Dmitry Stefantsov
3 years, 6 months ago (2017-06-14 11:07:50 UTC) #3
ahe
lgtm
3 years, 6 months ago (2017-06-15 12:13:37 UTC) #5
Dmitry Stefantsov
3 years, 6 months ago (2017-06-15 12:18:20 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
5982ace801dc4f222f3a327066d8494be3a969b3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698