Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 2938713002: fix super from constructors (Closed)

Created:
3 years, 6 months ago by Jennifer Messerly
Modified:
3 years, 6 months ago
Reviewers:
vsm
CC:
reviews_dartlang.org, turnidge, rmacnak
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -9 lines) Patch
M pkg/dev_compiler/lib/src/compiler/code_generator.dart View 7 chunks +14 lines, -9 lines 0 comments Download
A tests/language_strong/super_from_constructor_test.dart View 1 chunk +24 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Jennifer Messerly
3 years, 6 months ago (2017-06-13 23:32:41 UTC) #3
vsm
lgtm
3 years, 6 months ago (2017-06-13 23:39:05 UTC) #4
Jennifer Messerly
3 years, 6 months ago (2017-06-13 23:47:32 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:20001) manually as
c84847664336b8e5d9d64b23d8fec910fe4fb28a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698