Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Unified Diff: ios/chrome/browser/ui/payments/shipping_option_selection_mediator.mm

Issue 2938673003: [Payment Request] Selector view edit mode (Closed)
Patch Set: Addressed comments Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/payments/shipping_option_selection_mediator.mm
diff --git a/ios/chrome/browser/ui/payments/shipping_option_selection_mediator.mm b/ios/chrome/browser/ui/payments/shipping_option_selection_mediator.mm
index b7d341f7bfc675d46570bb1bcc10aee205540996..deda3a0cccd38773b0de90147381f11e183286bd 100644
--- a/ios/chrome/browser/ui/payments/shipping_option_selection_mediator.mm
+++ b/ios/chrome/browser/ui/payments/shipping_option_selection_mediator.mm
@@ -27,7 +27,10 @@
@property(nonatomic, assign) PaymentRequest* paymentRequest;
// The selectable items to display in the collection.
-@property(nonatomic, strong) NSArray<PaymentsTextItem*>* items;
+@property(nonatomic, strong) NSMutableArray<PaymentsTextItem*>* items;
+
+// Creates and stores the selectable items to display in the collection.
+- (void)loadItems;
@end
@@ -44,13 +47,17 @@
if (self) {
_paymentRequest = paymentRequest;
_selectedItemIndex = NSUIntegerMax;
- _items = [self createItems];
+ [self loadItems];
}
return self;
}
#pragma mark - PaymentRequestSelectorViewControllerDataSource
+- (BOOL)allowsEditMode {
+ return NO;
+}
+
- (CollectionViewItem*)headerItem {
if (!self.headerText.length)
return nil;
@@ -72,11 +79,10 @@
#pragma mark - Helper methods
-- (NSArray<PaymentsTextItem*>*)createItems {
+- (void)loadItems {
const std::vector<web::PaymentShippingOption*>& shippingOptions =
_paymentRequest->shipping_options();
- NSMutableArray<PaymentsTextItem*>* items =
- [NSMutableArray arrayWithCapacity:shippingOptions.size()];
+ _items = [NSMutableArray arrayWithCapacity:shippingOptions.size()];
for (size_t index = 0; index < shippingOptions.size(); ++index) {
web::PaymentShippingOption* shippingOption = shippingOptions[index];
DCHECK(shippingOption);
@@ -89,9 +95,8 @@
if (_paymentRequest->selected_shipping_option() == shippingOption)
_selectedItemIndex = index;
- [items addObject:item];
+ [_items addObject:item];
}
- return items;
}
@end

Powered by Google App Engine
This is Rietveld 408576698