[Payment Request] Selector view edit mode

ios/chrome/browser/ui/payments/payment_request_selector_view_controller.mm

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ios/chrome/browser/ui/payments/payment_request_selector_view_controller.h"
 
 #include "base/mac/foundation_util.h"
 #include "components/strings/grit/components_strings.h"
 #import "ios/chrome/browser/ui/autofill/cells/status_item.h"
 #import "ios/chrome/browser/ui/collection_view/cells/MDCCollectionViewCell+Chrome.h"
@@ skipping 50 matching lines @@
     UIBarButtonItem* backButton =
         [ChromeIcon templateBarButtonItemWithImage:[ChromeIcon backIcon]
                                             target:nil
                                             action:@selector(onBack)];
     backButton.accessibilityLabel = l10n_util::GetNSString(IDS_ACCNAME_BACK);
     self.navigationItem.leftBarButtonItem = backButton;
   }
   return self;
 }
 
+// Returns a custom edit bar button item.
+- (UIBarButtonItem*)editButton {
+  UIBarButtonItem* button = [[UIBarButtonItem alloc]
+      initWithTitle:l10n_util::GetNSString(IDS_IOS_NAVIGATION_BAR_EDIT_BUTTON)
+              style:UIBarButtonItemStyleDone
+             target:self
+             action:@selector(editButtonPressed)];
+  return button;
+}
+
+// Returns a custom done bar button item.
+- (UIBarButtonItem*)doneButton {
+  return [[UIBarButtonItem alloc]
+      initWithTitle:l10n_util::GetNSString(IDS_IOS_NAVIGATION_BAR_DONE_BUTTON)
+              style:UIBarButtonItemStyleDone
+             target:self
+             action:@selector(editButtonPressed)];
+}
+
+- (void)editButtonPressed {
+  PaymentRequestSelectorState newState =
+      self.dataSource.state == PaymentRequestSelectorStateEdit
+          ? PaymentRequestSelectorStateNormal
+          : PaymentRequestSelectorStateEdit;
+  if ([self.delegate
+          respondsToSelector:@selector
+          (paymentRequestSelectorViewController:didChangeToState:)]) {
+    [self.delegate paymentRequestSelectorViewController:self
+                                       didChangeToState:newState];
+  }
+}
+
 #pragma mark - PaymentRequestSelectorViewControllerActions
 
 - (void)onBack {
   [self.delegate paymentRequestSelectorViewControllerDidFinish:self];
 }
 
 #pragma mark - CollectionViewController methods
 
 - (void)loadModel {
   [super loadModel];
   CollectionViewModel* model = self.collectionViewModel;
 
+  // Set up trailing (edit or done) button.
+  if ([self.dataSource allowsEditMode]) {

[lpromero, 2017/06/14 09:10:12]

If !allowsEditMode, should you clear any present button?
self.navigationItem.rightBarButtonItem = nil for example?

[Moe, 2017/06/14 14:35:05]

allowsEditMode shouldn't change during the lifetime of the view controller, but
clearing the button is definitely safer. Done.

+    self.navigationItem.rightBarButtonItem =
+        self.dataSource.state == PaymentRequestSelectorStateEdit
+            ? [self doneButton]
+            : [self editButton];
+  }
+
   [model addSectionWithIdentifier:SectionIdentifierItems];
 
   // If the view controller is in the pending state, only display a spinner and
   // a message indicating the pending state.
   if (self.dataSource.state == PaymentRequestSelectorStatePending) {
     StatusItem* statusItem = [[StatusItem alloc] initWithType:ItemTypeSpinner];
     statusItem.state = StatusItemState::VERIFYING;
     statusItem.text = l10n_util::GetNSString(IDS_PAYMENTS_CHECKING_OPTION);
     [model addItem:statusItem toSectionWithIdentifier:SectionIdentifierItems];
     return;
   }
 
-  CollectionViewItem* headerItem = [self.dataSource headerItem];
-  if (headerItem) {
-    headerItem.type = ItemTypeHeader;
-    [model addItem:headerItem toSectionWithIdentifier:SectionIdentifierItems];
+  if (self.dataSource.state != PaymentRequestSelectorStateEdit) {
+    CollectionViewItem* headerItem = [self.dataSource headerItem];
+    if (headerItem) {
+      headerItem.type = ItemTypeHeader;
+      [model addItem:headerItem toSectionWithIdentifier:SectionIdentifierItems];
+    }
   }
 
   [[self.dataSource selectableItems]
       enumerateObjectsUsingBlock:^(
           CollectionViewItem<PaymentsHasAccessoryType>* item, NSUInteger index,
           BOOL* stop) {
         DCHECK([item respondsToSelector:@selector(accessoryType)]);
         item.type = ItemTypeSelectableItem;
         item.accessibilityTraits |= UIAccessibilityTraitButton;
-        item.accessoryType = (index == self.dataSource.selectedItemIndex)
-                                 ? MDCCollectionViewCellAccessoryCheckmark
-                                 : MDCCollectionViewCellAccessoryNone;
+        if (self.dataSource.state == PaymentRequestSelectorStateEdit) {
+          item.accessoryType =
+              MDCCollectionViewCellAccessoryDisclosureIndicator;
+        } else {
+          item.accessoryType = (index == self.dataSource.selectedItemIndex)
+                                   ? MDCCollectionViewCellAccessoryCheckmark
+                                   : MDCCollectionViewCellAccessoryNone;
+        }
         [model addItem:item toSectionWithIdentifier:SectionIdentifierItems];
       }];
 
-  CollectionViewItem* addButtonItem = [self.dataSource addButtonItem];
-  if (addButtonItem) {
-    addButtonItem.type = ItemTypeAddItem;
-    addButtonItem.accessibilityTraits |= UIAccessibilityTraitButton;
-    [model addItem:addButtonItem
-        toSectionWithIdentifier:SectionIdentifierItems];
+  if (self.dataSource.state != PaymentRequestSelectorStateEdit) {
+    CollectionViewItem* addButtonItem = [self.dataSource addButtonItem];
+    if (addButtonItem) {
+      addButtonItem.type = ItemTypeAddItem;
+      addButtonItem.accessibilityTraits |= UIAccessibilityTraitButton;
+      [model addItem:addButtonItem
+          toSectionWithIdentifier:SectionIdentifierItems];
+    }
   }
 }
 
 - (void)viewDidLoad {
   [super viewDidLoad];
   self.collectionView.accessibilityIdentifier =
       kPaymentRequestSelectorCollectionViewAccessibilityID;
 
   // Customize collection view settings.
   self.styler.cellStyle = MDCCollectionViewCellStyleCard;
@@ skipping 52 matching lines @@
 
 #pragma mark UICollectionViewDelegate
 
 - (void)collectionView:(UICollectionView*)collectionView
     didSelectItemAtIndexPath:(NSIndexPath*)indexPath {
   [super collectionView:collectionView didSelectItemAtIndexPath:indexPath];
 
   CollectionViewModel* model = self.collectionViewModel;
 
   CollectionViewItem* item = [model itemAtIndexPath:indexPath];
+
+  if (self.dataSource.state == PaymentRequestSelectorStateEdit) {
+    DCHECK(item.type == ItemTypeSelectableItem);
+    // Notify the delegate of the selection.
+    NSUInteger index =
+        [self.collectionViewModel indexInItemTypeForIndexPath:indexPath];
+    DCHECK(index < [[self.dataSource selectableItems] count]);
+    if ([self.delegate
+            respondsToSelector:@selector
+            (paymentRequestSelectorViewController:didSelectItemAtIndexForEditing
+                                                    :)]) {

[lpromero, 2017/06/14 09:10:13]

No action needed: this line is awesome :p

[Moe, 2017/06/14 14:35:05]

:)])

+      [self.delegate paymentRequestSelectorViewController:self
+                           didSelectItemAtIndexForEditing:index];
+    }
+    return;
+  }
+
   switch (item.type) {
     case ItemTypeSelectableItem: {
       // Update the currently selected cell, if any.
       if (self.dataSource.selectedItemIndex != NSUIntegerMax) {
         DCHECK(self.dataSource.selectedItemIndex <
                [[self.dataSource selectableItems] count]);
         CollectionViewItem<PaymentsHasAccessoryType>* oldSelectedItem =
             [[self.dataSource selectableItems]
                 objectAtIndex:self.dataSource.selectedItemIndex];
         oldSelectedItem.accessoryType = MDCCollectionViewCellAccessoryNone;
@@ skipping 49 matching lines @@
     hidesInkViewAtIndexPath:(NSIndexPath*)indexPath {
   NSInteger type = [self.collectionViewModel itemTypeForIndexPath:indexPath];
   if (type == ItemTypeHeader) {
     return YES;
   } else {
     return NO;
   }
 }
 
 @end