tools/metrics/histograms/enums.xml

Index: tools/metrics/histograms/enums.xml
diff --git a/tools/metrics/histograms/enums.xml b/tools/metrics/histograms/enums.xml
index 8a295e5af1f6c506277f40e5e40d82b8767fad03..f718c53afda95ace0f0aeace09fbc9d0089a3a77 100644
--- a/tools/metrics/histograms/enums.xml
+++ b/tools/metrics/histograms/enums.xml
@@ -8702,7 +8702,31 @@ uploading your change for review.  These are checked by presubmit scripts.
   <int value="2" label="Unknown"/>
 </enum>
 
-<enum name="DxgiFramePresentationMode">
+
+<enum name="DXGI_COLOR_SPACE_TYPE" type="int">

[Mark P, 2017/06/26 20:40:11]

It looks like these come from a third-party .h.  Can you guarantee the values
will never change?  Usually in cases like this people built a translation layer
from the third-party enum to a stable enum that can be used for UMA.

https://chromium.googlesource.com/chromium/src.git/+/HEAD/tools/metrics/histo...

[hubbe, 2017/06/26 21:01:21]

These come from a microsoft API, which may be extended, but existing values
cannot change without breaking compatibility.

[Mark P, 2017/06/26 21:30:59]

Acknowledged.

+  <int value="0" label="DXGI_COLOR_SPACE_RGB_FULL_G22_NONE_P709"/>
+  <int value="1" label="DXGI_COLOR_SPACE_RGB_FULL_G10_NONE_P709"/>
+  <int value="2" label="DXGI_COLOR_SPACE_RGB_STUDIO_G22_NONE_P709"/>
+  <int value="3" label="DXGI_COLOR_SPACE_RGB_STUDIO_G22_NONE_P2020"/>
+  <int value="4" label="DXGI_COLOR_SPACE_RESERVED"/>
+  <int value="5" label="DXGI_COLOR_SPACE_YCBCR_FULL_G22_NONE_P709_X601"/>
+  <int value="6" label="DXGI_COLOR_SPACE_YCBCR_STUDIO_G22_LEFT_P601"/>
+  <int value="7" label="DXGI_COLOR_SPACE_YCBCR_FULL_G22_LEFT_P601"/>
+  <int value="8" label="DXGI_COLOR_SPACE_YCBCR_STUDIO_G22_LEFT_P709"/>
+  <int value="9" label="DXGI_COLOR_SPACE_YCBCR_FULL_G22_LEFT_P709"/>
+  <int value="10" label="DXGI_COLOR_SPACE_YCBCR_STUDIO_G22_LEFT_P2020"/>
+  <int value="11" label="DXGI_COLOR_SPACE_YCBCR_FULL_G22_LEFT_P2020"/>
+  <int value="12" label="DXGI_COLOR_SPACE_RGB_FULL_G2084_NONE_P2020"/>
+  <int value="13" label="DXGI_COLOR_SPACE_YCBCR_STUDIO_G2084_LEFT_P2020"/>
+  <int value="14" label="DXGI_COLOR_SPACE_RGB_STUDIO_G2084_NONE_P2020"/>
+  <int value="15" label="DXGI_COLOR_SPACE_YCBCR_STUDIO_G22_TOPLEFT_P2020"/>
+  <int value="16" label="DXGI_COLOR_SPACE_YCBCR_STUDIO_G2084_TOPLEFT_P2020"/>
+  <int value="17" label="DXGI_COLOR_SPACE_RGB_FULL_G22_NONE_P2020"/>
+  <int value="18" label="DXGI_COLOR_SPACE_YCBCR_STUDIO_GHLG_TOPLEFT_P2020"/>
+  <int value="19" label="DXGI_COLOR_SPACE_YCBCR_FULL_GHLG_TOPLEFT_P2020"/>
+</enum>
+
+<enum name="DxgiFramePresentationMode" type="int">
   <int value="0" label="Composed"/>
   <int value="1" label="Overlay"/>
   <int value="2" label="None (Unknown)"/>