Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 293853002: revert r171206: "Add transaction detail params to requestAutocomplete()." (Closed)

Created:
6 years, 7 months ago by Evan Stade
Modified:
6 years, 6 months ago
Reviewers:
tkent, esprehn
CC:
blink-reviews, jamesr, arv+blink, blink-reviews-html_chromium.org, abarth-chromium, dglazkov+blink, Inactive, Nate Chapin, watchdog-blink-watchlist_google.com, gavinp+loader_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

revert r171206: "Add transaction detail params to requestAutocomplete()." Since rAc was adopted into the standard, we revisited this and decided to do it a different way. This "revert" does keep the minor change about removing the extra param to WebAutofillClient::didRequestAutocomplete. BUG=354897 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175608

Patch Set 1 #

Total comments: 2

Patch Set 2 : remove include #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -126 lines) Patch
M Source/core/html/HTMLFormElement.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLFormElement.cpp View 1 3 chunks +2 lines, -3 lines 0 comments Download
M Source/core/html/HTMLFormElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/EmptyClients.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/EmptyClients.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/FrameLoaderClient.h View 2 chunks +1 line, -2 lines 0 comments Download
M Source/web/FrameLoaderClientImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/FrameLoaderClientImpl.cpp View 3 chunks +2 lines, -4 lines 0 comments Download
D Source/web/WebAutocompleteParams.cpp View 1 chunk +0 lines, -50 lines 0 comments Download
M Source/web/web.gypi View 1 1 chunk +0 lines, -1 line 0 comments Download
D public/web/WebAutocompleteParams.h View 1 chunk +0 lines, -59 lines 0 comments Download
M public/web/WebAutofillClient.h View 1 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 23 (0 generated)
Evan Stade
depends on https://codereview.chromium.org/299553002/
6 years, 7 months ago (2014-05-23 02:06:52 UTC) #1
Evan Stade
ping?
6 years, 6 months ago (2014-05-29 01:02:14 UTC) #2
esprehn
rslgtm
6 years, 6 months ago (2014-05-29 01:04:47 UTC) #3
esprehn
https://codereview.chromium.org/293853002/diff/1/public/web/WebAutofillClient.h File public/web/WebAutofillClient.h (right): https://codereview.chromium.org/293853002/diff/1/public/web/WebAutofillClient.h#newcode34 public/web/WebAutofillClient.h:34: #include "WebFrame.h" Why add WebFrame.
6 years, 6 months ago (2014-05-29 01:04:54 UTC) #4
Evan Stade
https://codereview.chromium.org/293853002/diff/1/public/web/WebAutofillClient.h File public/web/WebAutofillClient.h (right): https://codereview.chromium.org/293853002/diff/1/public/web/WebAutofillClient.h#newcode34 public/web/WebAutofillClient.h:34: #include "WebFrame.h" On 2014/05/29 01:04:54, esprehn wrote: > Why ...
6 years, 6 months ago (2014-05-29 20:53:57 UTC) #5
Evan Stade
The CQ bit was checked by estade@chromium.org
6 years, 6 months ago (2014-05-29 20:54:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/293853002/20001
6 years, 6 months ago (2014-05-29 20:55:49 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: blink_presubmit on tryserver.blink ...
6 years, 6 months ago (2014-05-29 22:39:56 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-05-29 22:56:57 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/6476)
6 years, 6 months ago (2014-05-29 22:56:59 UTC) #10
Evan Stade
+tkent for OWNERS review of public/web
6 years, 6 months ago (2014-05-30 14:51:09 UTC) #11
tkent
lgtm
6 years, 6 months ago (2014-06-01 23:13:12 UTC) #12
Evan Stade
The CQ bit was checked by estade@chromium.org
6 years, 6 months ago (2014-06-02 17:53:17 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/293853002/20001
6 years, 6 months ago (2014-06-02 17:53:41 UTC) #14
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_gpu on tryserver.chromium.gpu ...
6 years, 6 months ago (2014-06-02 19:26:45 UTC) #15
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-02 20:00:22 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/22946)
6 years, 6 months ago (2014-06-02 20:00:23 UTC) #17
esprehn
Any luck here?
6 years, 6 months ago (2014-06-05 01:12:23 UTC) #18
Evan Stade
On 2014/06/05 01:12:23, esprehn wrote: > Any luck here? thanks for pinging, I think the ...
6 years, 6 months ago (2014-06-05 01:25:13 UTC) #19
Evan Stade
On 2014/06/05 01:25:13, Evan Stade wrote: > On 2014/06/05 01:12:23, esprehn wrote: > > Any ...
6 years, 6 months ago (2014-06-05 16:22:40 UTC) #20
Evan Stade
The CQ bit was checked by estade@chromium.org
6 years, 6 months ago (2014-06-05 23:32:09 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/293853002/20001
6 years, 6 months ago (2014-06-05 23:32:19 UTC) #22
commit-bot: I haz the power
6 years, 6 months ago (2014-06-06 00:48:03 UTC) #23
Message was sent while issue was closed.
Change committed as 175608

Powered by Google App Engine
This is Rietveld 408576698