third_party/WebKit/Source/devtools/front_end/network/NetworkConfigView.js - Issue 2938503002: DevTools: unify Network & CPU throttling

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkConfigView.js

Issue 2938503002: DevTools: unify Network & CPU throttling (Closed)

Patch Set: fmt Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/devtools/front_end/mobile_throttling/ThrottlingSettingsTab.js ('K') | « third_party/WebKit/Source/devtools/front_end/mobile_throttling/throttlingSettingsTab.css ('k') | third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js » ('j') | third_party/WebKit/Source/devtools/front_end/sdk/MobileThrottling.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/network/NetworkConfigView.js

diff --git a/third_party/WebKit/Source/devtools/front_end/network/NetworkConfigView.js b/third_party/WebKit/Source/devtools/front_end/network/NetworkConfigView.js

index 3b317219e808617cc0018b2552e20e6bbad9bab8..3c95340fed3429b517e5ac1675ede02673dbe6bb 100644

--- a/third_party/WebKit/Source/devtools/front_end/network/NetworkConfigView.js

+++ b/third_party/WebKit/Source/devtools/front_end/network/NetworkConfigView.js

@@ -111,8 +111,8 @@ Network.NetworkConfigView = class extends UI.VBox {

}

_createNetworkThrottlingSection() {

- var section = this._createSection(Common.UIString('Network throttling'), 'network-config-throttling');

- MobileThrottling.NetworkConditionsSelector.decorateSelect(

+ var section = this._createSection(Common.UIString('Mobile throttling'), 'network-config-throttling');

dgozman 2017/06/13 01:47:08 Drop mobile here as well?

chenwilliam 2017/06/13 21:54:51 Done.

+ MobileThrottling.ThrottlingSelector.decorateSelect(

/** @type {!HTMLSelectElement} */ (section.createChild('select', 'chrome-select')));

}