DevTools: unify Network & CPU throttling

third_party/WebKit/Source/devtools/front_end/sdk/MobileThrottling.js

+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+SDK.MobileThrottling = {};

[dgozman, 2017/06/13 01:47:08]

Move it back to NetworkManager.

[chenwilliam, 2017/06/13 21:54:52]

It seemed bad to me that NetworkManager knows about cpu throttling (e.g.
SDK.NetworkManager.Conditions). I'd like to do a f/u refactoring where there's
types:

SDK.NetworkManager.Conditions which is type: {download: number, upload: number,
latency: number, title: string}

SDK.CPUThrottling.Conditions which is type: {cpuThrottlingRate: number, title:
string}

and 

SDK.MobileThrottling.Conditions is a union of those two types.

What do you think?

[dgozman, 2017/06/13 23:18:39]

Great idea, but move MobileThrottling.Conditions to mobile_throttling module
instead. It does not have to be in SDK. Let's also do it in this patch.

+
+/** @typedef {{download: number, upload: number, latency: number, title: string, cpuThrottlingRate: number}} */
+SDK.MobileThrottling.Conditions;
+
+/** @type {!SDK.MobileThrottling.Conditions} */
+SDK.MobileThrottling.NoThrottlingConditions = {
+  title: Common.UIString('No throttling'),
+  download: -1,
+  upload: -1,
+  latency: 0,
+  cpuThrottlingRate: 1,
+};
+
+/** @type {!SDK.MobileThrottling.Conditions} */
+SDK.MobileThrottling.OfflineConditions = {
+  title: Common.UIString('Offline'),
+  download: 0,
+  upload: 0,
+  latency: 0,
+  cpuThrottlingRate: 1,
+};