DevTools: unify Network & CPU throttling

third_party/WebKit/Source/devtools/front_end/mobile_throttling/CPUThrottlingManager.js

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @implements {SDK.SDKModelObserver<!SDK.EmulationModel>}
  */
 MobileThrottling.CPUThrottlingManager = class extends Common.Object {

[dgozman, 2017/06/30 00:54:16]

Let's rename this one to ThrottlingManager, put internal settings at it, and
turn static decorate/create controls methods into it's member methods.

[chenwilliam, 2017/06/30 22:01:11]

Done.

   constructor() {
     super();
-    this._throttlingRate = 1;  // No throttling
+    this._throttlingRate = MobileThrottling.CPUThrottlingRates.NoThrottling;
     /** @type {!Set<!UI.ToolbarComboBox>} */
     this._controls = new Set();
-    this._rates = [1, 2, 5, 10, 20];
+    this._rates = [
+      MobileThrottling.CPUThrottlingRates.NoThrottling,
+      MobileThrottling.CPUThrottlingRates.MidTierMobile,
+      MobileThrottling.CPUThrottlingRates.LowEndMobile,
+    ];
     SDK.targetManager.observeModels(SDK.EmulationModel, this);
   }
 
   /**
-   * @param {number} index
+   * @return {number}
    */
-  _setRateIndex(index) {
-    this._throttlingRate = this._rates[index];
+  rate() {

[dgozman, 2017/06/30 00:54:16]

And rename this to cpuThrottlingRate().

[chenwilliam, 2017/06/30 22:01:11]

Done.

+    return this._throttlingRate;
+  }
+
+  /**
+   * @param {number} rate
+   */
+  setRate(rate) {
+    this._throttlingRate = rate;
     for (var emulationModel of SDK.targetManager.models(SDK.EmulationModel))
       emulationModel.setCPUThrottlingRate(this._throttlingRate);
     var icon = null;
     if (this._throttlingRate !== 1) {
       Host.userMetrics.actionTaken(Host.UserMetrics.Action.CpuThrottlingEnabled);
       icon = UI.Icon.create('smallicon-warning');
       icon.title = Common.UIString('CPU throttling is enabled');
     }
+    var index = this._rates.indexOf(this._throttlingRate);
     for (var control of this._controls)
       control.setSelectedIndex(index);
     UI.inspectorView.setPanelIcon('timeline', icon);
-    this.dispatchEventToListeners(MobileThrottling.CPUThrottlingManager.Events.RateChanged);
+    this.dispatchEventToListeners(MobileThrottling.CPUThrottlingManager.Events.RateChanged, this._throttlingRate);
   }
 
   /**
-   * @return {number}
-   */
-  rate() {
-    return this._throttlingRate;
-  }
-
-  /**
    * @override
    * @param {!SDK.EmulationModel} emulationModel
    */
   modelAdded(emulationModel) {
     if (this._throttlingRate !== 1)
       emulationModel.setCPUThrottlingRate(this._throttlingRate);
   }
 
   /**
    * @override
    * @param {!SDK.EmulationModel} emulationModel
    */
   modelRemoved(emulationModel) {
   }
 
   /**
    * @return {!UI.ToolbarComboBox}
    */
   createControl() {
-    var control = new UI.ToolbarComboBox(event => this._setRateIndex(event.target.selectedIndex));
+    var control = new UI.ToolbarComboBox(event => this.setRate(this._rates[event.target.selectedIndex]));
     this._controls.add(control);
     var currentRate = this._throttlingRate;
 
     for (var i = 0; i < this._rates.length; ++i) {
       var rate = this._rates[i];
       var title = rate === 1 ? Common.UIString('No throttling') : Common.UIString('%d\xD7 slowdown', rate);
       var option = control.createOption(title);
       control.addOption(option);
       if (currentRate === rate)
         control.setSelectedIndex(i);
     }
     return control;
   }
 
   /**
    * @param {!UI.ToolbarComboBox} control
    */
   disposeControl(control) {
     this._controls.delete(control);
   }
 };
 
 /** @enum {symbol} */
 MobileThrottling.CPUThrottlingManager.Events = {
   RateChanged: Symbol('RateChanged')
 };
+
+/** @type {!MobileThrottling.CPUThrottlingManager} */
+MobileThrottling.cpuThrottlingManager;

[dgozman, 2017/06/30 00:54:16]

Let's make this a lazy function to avoid instantiating in Main.

[chenwilliam, 2017/06/30 22:01:11]

Done.