Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issue 2938443003: Add type inference for assignments to `this[...]` (Closed)

Created:
3 years, 6 months ago by Paul Berry
Modified:
3 years, 6 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+863 lines, -15 lines) Patch
M pkg/front_end/lib/src/fasta/kernel/fasta_accessors.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/frontend_accessors.dart View 2 chunks +36 lines, -15 lines 0 comments Download
M pkg/front_end/test/fasta/kompile.status View 1 chunk +2 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/infer_assign_to_index_this.dart View 1 chunk +57 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/infer_assign_to_index_this.dart.direct.expect View 1 chunk +59 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/infer_assign_to_index_this.dart.outline.expect View 1 chunk +42 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/infer_assign_to_index_this.dart.strong.expect View 1 chunk +59 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/infer_assign_to_index_this_upwards.dart View 1 chunk +168 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/infer_assign_to_index_this_upwards.dart.direct.expect View 1 chunk +176 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/infer_assign_to_index_this_upwards.dart.outline.expect View 1 chunk +84 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/infer_assign_to_index_this_upwards.dart.strong.expect View 1 chunk +176 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Paul Berry
3 years, 6 months ago (2017-06-12 20:57:49 UTC) #3
scheglov
LGTM
3 years, 6 months ago (2017-06-12 21:00:11 UTC) #4
Paul Berry
3 years, 6 months ago (2017-06-12 21:01:08 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d4a64e52e7343ff17cde55a9305a6312aac878de (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698