Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2155)

Unified Diff: chrome/browser/resource_coordinator/resource_coordinator_web_contents_observer.h

Issue 2938443002: [GRC] UKM Support (Closed)
Patch Set: Address reviewer feedback Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resource_coordinator/resource_coordinator_web_contents_observer.h
diff --git a/chrome/browser/resource_coordinator/resource_coordinator_web_contents_observer.h b/chrome/browser/resource_coordinator/resource_coordinator_web_contents_observer.h
index db50288a681bf46323395a47fca6a2b10f9c1b90..16d9e7c7bc16633268e1976a90f8eb1551977819 100644
--- a/chrome/browser/resource_coordinator/resource_coordinator_web_contents_observer.h
+++ b/chrome/browser/resource_coordinator/resource_coordinator_web_contents_observer.h
@@ -5,10 +5,13 @@
#ifndef CHROME_BROWSER_RESOURCE_COORDINATOR_RESOURCE_COORDINATOR_WEB_CONTENTS_OBSERVER_H_
#define CHROME_BROWSER_RESOURCE_COORDINATOR_RESOURCE_COORDINATOR_WEB_CONTENTS_OBSERVER_H_
+#include <memory>
+
#include "base/macros.h"
#include "content/public/browser/web_contents_observer.h"
#include "content/public/browser/web_contents_user_data.h"
#include "services/resource_coordinator/public/cpp/resource_coordinator_interface.h"
+#include "services/resource_coordinator/public/interfaces/service_callbacks.mojom.h"
class ResourceCoordinatorWebContentsObserver
: public content::WebContentsObserver,
@@ -17,6 +20,7 @@ class ResourceCoordinatorWebContentsObserver
public:
~ResourceCoordinatorWebContentsObserver() override;
+ static bool ukm_recorder_initialized;
static bool IsEnabled();
resource_coordinator::ResourceCoordinatorInterface*
@@ -30,6 +34,9 @@ class ResourceCoordinatorWebContentsObserver
void DidFinishNavigation(
content::NavigationHandle* navigation_handle) override;
+ void EnsureUkmRecorderInterface();
+ void MaybeSetUkmRecorderInterface(bool ukm_recorder_already_initialized);
+
private:
explicit ResourceCoordinatorWebContentsObserver(
content::WebContents* web_contents);
@@ -40,6 +47,8 @@ class ResourceCoordinatorWebContentsObserver
std::unique_ptr<resource_coordinator::ResourceCoordinatorInterface>
tab_resource_coordinator_;
+ resource_coordinator::mojom::ServiceCallbacksPtr service_callbacks_;
+
DISALLOW_COPY_AND_ASSIGN(ResourceCoordinatorWebContentsObserver);
};

Powered by Google App Engine
This is Rietveld 408576698