Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Unified Diff: content/public/app/mojo/content_browser_manifest.json

Issue 2938443002: [GRC] UKM Support (Closed)
Patch Set: Address reviewer feedback and rebase Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/app/mojo/content_browser_manifest.json
diff --git a/content/public/app/mojo/content_browser_manifest.json b/content/public/app/mojo/content_browser_manifest.json
index 0326e8616e2d1a1a47742500b24d4a10cec5930c..8432dbe8b8cfb36fc3bbaaacfb4b6112a9491f89 100644
--- a/content/public/app/mojo/content_browser_manifest.json
+++ b/content/public/app/mojo/content_browser_manifest.json
@@ -57,8 +57,10 @@
},
"requires": {
"*": [ "app" ],
+ // TODO(matthalp,oysteine,holte) isolate ukm capabilities from the render
dcheng 2017/06/23 16:10:35 Nit: 80 chars please (same below)
matthalp 2017/06/23 16:36:28 Done.
+ // capabilities and then replace the render capabilities with them
// In classic ash, the browser supplies ash interfaces to itself.
- "content_browser": [ "ash", "display", "memory_instrumentation" ],
+ "content_browser": [ "ash", "display", "memory_instrumentation", "renderer" ],
dcheng 2017/06/23 16:10:35 Maybe we should split the renderer capability to b
matthalp 2017/06/23 16:36:28 holte@ what do you think? I am not sure what entit
Steven Holte 2017/06/23 18:11:02 AFAIK nothing has actually started using the UKM m
"content_gpu": [ "browser" ],
"content_plugin": [ "browser" ],
"content_renderer": [ "browser" ],
@@ -83,9 +85,8 @@
"barcode_detection",
"face_detection",
"text_detection"
-
],
- "resource_coordinator": [ "coordination_unit" ],
+ "resource_coordinator": [ "coordination_unit", "service_callbacks" ],
"video_capture": [ "capture", "tests" ]
}
},

Powered by Google App Engine
This is Rietveld 408576698