Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 293843002: checklicenses: Do not report unused suppressions when checking a sub-directory. (Closed)

Created:
6 years, 7 months ago by Lei Zhang
Modified:
6 years, 7 months ago
Reviewers:
Paweł Hajdan Jr.
CC:
chromium-reviews
Visibility:
Public.

Description

checklicenses: Do not report unused suppressions when checking a sub-directory. In this case, it's not very useful and full of false positives. NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271711

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M tools/checklicenses/checklicenses.py View 1 chunk +6 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Lei Zhang
6 years, 7 months ago (2014-05-19 22:47:24 UTC) #1
Paweł Hajdan Jr.
LGTM
6 years, 7 months ago (2014-05-20 12:39:45 UTC) #2
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 7 months ago (2014-05-20 17:50:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/293843002/1
6 years, 7 months ago (2014-05-20 17:52:08 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-05-20 18:06:50 UTC) #5
Message was sent while issue was closed.
Change committed as 271711

Powered by Google App Engine
This is Rietveld 408576698