Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2938423003: Implement override-based inference of instance fields. (Closed)

Created:
3 years, 6 months ago by Paul Berry
Modified:
3 years, 6 months ago
Reviewers:
ahe, scheglov
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Implement override-based inference of instance fields. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/ba14751f55e59674dbf7435803ba69a90e557e5d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1583 lines, -150 lines) Patch
M pkg/analyzer/test/src/task/strong/front_end_inference_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_class_builder.dart View 2 chunks +10 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_field_builder.dart View 4 chunks +23 lines, -21 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart View 1 chunk +17 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/type_inference/type_inference_engine.dart View 7 chunks +125 lines, -56 lines 0 comments Download
M pkg/front_end/test/fasta/kompile.status View 2 chunks +14 lines, -0 lines 0 comments Download
M pkg/front_end/test/fasta/strong.status View 1 chunk +1 line, -3 lines 0 comments Download
M pkg/front_end/testcases/inference/infer_correctly_on_multiple_variables_declared_together.dart View 1 chunk +2 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/infer_correctly_on_multiple_variables_declared_together.dart.strong.expect View 1 chunk +34 lines, -0 lines 0 comments Download
A + pkg/front_end/testcases/inference/infer_field_from_later_inferred_field.dart View 1 chunk +5 lines, -8 lines 0 comments Download
A pkg/front_end/testcases/inference/infer_field_from_later_inferred_field.dart.direct.expect View 1 chunk +17 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/infer_field_from_later_inferred_field.dart.outline.expect View 1 chunk +16 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/infer_field_from_later_inferred_field.dart.strong.expect View 1 chunk +17 lines, -0 lines 0 comments Download
A + pkg/front_end/testcases/inference/infer_field_getter_setter_mismatch.dart View 1 chunk +8 lines, -8 lines 0 comments Download
A pkg/front_end/testcases/inference/infer_field_getter_setter_mismatch.dart.direct.expect View 1 chunk +18 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/infer_field_getter_setter_mismatch.dart.outline.expect View 1 chunk +17 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/infer_field_getter_setter_mismatch.dart.strong.expect View 1 chunk +18 lines, -0 lines 0 comments Download
A + pkg/front_end/testcases/inference/infer_field_override_getter_overrides_setter.dart View 1 chunk +10 lines, -7 lines 0 comments Download
A pkg/front_end/testcases/inference/infer_field_override_getter_overrides_setter.dart.direct.expect View 1 chunk +23 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/infer_field_override_getter_overrides_setter.dart.outline.expect View 1 chunk +21 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/infer_field_override_getter_overrides_setter.dart.strong.expect View 1 chunk +23 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/infer_field_override_multiple.dart View 1 chunk +43 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/infer_field_override_multiple.dart.direct.expect View 1 chunk +53 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/infer_field_override_multiple.dart.outline.expect View 1 chunk +46 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/infer_field_override_multiple.dart.strong.expect View 1 chunk +53 lines, -0 lines 0 comments Download
A + pkg/front_end/testcases/inference/infer_field_override_of_override.dart View 1 chunk +8 lines, -7 lines 0 comments Download
A pkg/front_end/testcases/inference/infer_field_override_of_override.dart.direct.expect View 1 chunk +23 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/infer_field_override_of_override.dart.outline.expect View 1 chunk +21 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/infer_field_override_of_override.dart.strong.expect View 1 chunk +23 lines, -0 lines 0 comments Download
A + pkg/front_end/testcases/inference/infer_field_override_setter_overrides_getter.dart View 1 chunk +10 lines, -7 lines 0 comments Download
A pkg/front_end/testcases/inference/infer_field_override_setter_overrides_getter.dart.direct.expect View 1 chunk +23 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/infer_field_override_setter_overrides_getter.dart.outline.expect View 1 chunk +21 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/infer_field_override_setter_overrides_getter.dart.strong.expect View 1 chunk +23 lines, -0 lines 0 comments Download
A + pkg/front_end/testcases/inference/infer_field_override_with_substitution.dart View 1 chunk +9 lines, -8 lines 0 comments Download
A pkg/front_end/testcases/inference/infer_field_override_with_substitution.dart.direct.expect View 1 chunk +21 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/infer_field_override_with_substitution.dart.outline.expect View 1 chunk +20 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/infer_field_override_with_substitution.dart.strong.expect View 1 chunk +21 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/infer_field_overrides_getter.dart View 1 chunk +36 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/infer_field_overrides_getter.dart.direct.expect View 1 chunk +50 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/infer_field_overrides_getter.dart.outline.expect View 1 chunk +44 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/infer_field_overrides_getter.dart.strong.expect View 1 chunk +50 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/infer_field_overrides_setter.dart View 1 chunk +36 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/infer_field_overrides_setter.dart.direct.expect View 1 chunk +49 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/infer_field_overrides_setter.dart.outline.expect View 1 chunk +44 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/infer_field_overrides_setter.dart.strong.expect View 1 chunk +49 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/infer_field_static.dart View 1 chunk +28 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/infer_field_static.dart.direct.expect View 1 chunk +26 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/infer_field_static.dart.outline.expect View 1 chunk +24 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/infer_field_static.dart.strong.expect View 1 chunk +26 lines, -0 lines 0 comments Download
A + pkg/front_end/testcases/inference/infer_final_field_getter_and_setter.dart View 1 chunk +8 lines, -8 lines 0 comments Download
A pkg/front_end/testcases/inference/infer_final_field_getter_and_setter.dart.direct.expect View 1 chunk +18 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/infer_final_field_getter_and_setter.dart.outline.expect View 1 chunk +17 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/infer_final_field_getter_and_setter.dart.strong.expect View 1 chunk +18 lines, -0 lines 0 comments Download
A + pkg/front_end/testcases/inference/infer_final_field_getter_only.dart View 1 chunk +7 lines, -8 lines 0 comments Download
A pkg/front_end/testcases/inference/infer_final_field_getter_only.dart.direct.expect View 1 chunk +17 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/infer_final_field_getter_only.dart.outline.expect View 1 chunk +16 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/infer_final_field_getter_only.dart.strong.expect View 1 chunk +17 lines, -0 lines 0 comments Download
A + pkg/front_end/testcases/inference/infer_final_field_setter_only.dart View 1 chunk +7 lines, -8 lines 0 comments Download
A pkg/front_end/testcases/inference/infer_final_field_setter_only.dart.direct.expect View 1 chunk +17 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/infer_final_field_setter_only.dart.outline.expect View 1 chunk +16 lines, -0 lines 0 comments Download
M pkg/front_end/testcases/inference/infer_from_rhs_only_if_it_wont_conflict_with_overridden_fields.dart View 1 chunk +2 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/infer_from_rhs_only_if_it_wont_conflict_with_overridden_fields.dart.strong.expect View 1 chunk +21 lines, -0 lines 0 comments Download
M pkg/front_end/testcases/inference/infer_from_rhs_only_if_it_wont_conflict_with_overridden_fields2.dart View 1 chunk +2 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/infer_from_rhs_only_if_it_wont_conflict_with_overridden_fields2.dart.strong.expect View 1 chunk +21 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference_new/field_inference_circularity.dart View 1 chunk +23 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference_new/field_inference_circularity.dart.direct.expect View 1 chunk +19 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference_new/field_inference_circularity.dart.outline.expect View 1 chunk +18 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference_new/field_inference_circularity.dart.strong.expect View 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
I only need a review from one of you
3 years, 6 months ago (2017-06-16 22:23:41 UTC) #2
scheglov
LGTM
3 years, 6 months ago (2017-06-16 23:21:16 UTC) #3
Paul Berry
3 years, 6 months ago (2017-06-17 13:27:33 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
ba14751f55e59674dbf7435803ba69a90e557e5d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698