Fix Widget::InitParams::activatable logic

ui/views/widget/widget_delegate.h

Index: ui/views/widget/widget_delegate.h
diff --git a/ui/views/widget/widget_delegate.h b/ui/views/widget/widget_delegate.h
index 1637ae9886e14b95dd169e17343ddd717b16d8a8..03e6ed94097fbda9ac40afe19f4d4b54db306be4 100644
--- a/ui/views/widget/widget_delegate.h
+++ b/ui/views/widget/widget_delegate.h
@@ -30,6 +30,11 @@ class VIEWS_EXPORT WidgetDelegate {
  public:
   WidgetDelegate();
 
+  // Sets the default value of CanActivate().

[sky, 2014/05/20 15:02:55]

Why default here? Isn't this just set_can_activate? Also, can any overrides of
CanActivate be changed to explicitly set_can_activate now?

[pkotwicz, 2014/05/20 16:13:52]

I do not think that's possible. In particular, I think that
BrowserView::CanActivate() cannot be easily simplified to just returning a
boolean.

I called this set_default_can_activate() because I thought it was confusing for
WidgetDelegate::CanActivate() to return true by default regardless of the widget
type. I do not pass in a Widget::InitParams::Type because I want to avoid
duplicating the computation of whether a widget should be activatable.

[pkotwicz, 2014/05/20 16:33:30]

ToastContentsView is the only easy override to change. (Which I have changed in
my latest patch set)
With some work, I can probably change the overrides for BubbleDelegateView and
TrayBubbleView.

[sky, 2014/05/20 17:33:20]

I still prefer set_can_activate. Rationale being the corresponding method this
effects is CanActivate, not CAnDefaultActivate.

+  void set_default_can_activate(bool can_activate) {
+    default_can_activate_ = can_activate;
+  }
+
   // Called whenever the widget's position changes.
   virtual void OnWidgetMove();
 
@@ -181,6 +186,8 @@ class VIEWS_EXPORT WidgetDelegate {
  private:
   View* default_contents_view_;
 
+  bool default_can_activate_;
+
   DISALLOW_COPY_AND_ASSIGN(WidgetDelegate);
 };