Fix Widget::InitParams::activatable logic

ui/views/widget/widget.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_VIEWS_WIDGET_WIDGET_H_
 #define UI_VIEWS_WIDGET_WIDGET_H_
 
 #include <set>
 #include <stack>
 #include <vector>
@@ skipping 176 matching lines @@
     Type type;
     // If NULL, a default implementation will be constructed.
     WidgetDelegate* delegate;
     bool child;
     // If TRANSLUCENT_WINDOW, the widget may be fully or partially transparent.
     // If OPAQUE_WINDOW, we can perform optimizations based on the widget being
     // fully opaque.  Defaults to TRANSLUCENT_WINDOW if
     // ViewsDelegate::UseTransparentWindows().  Defaults to OPAQUE_WINDOW for
     // non-window widgets.
     WindowOpacity opacity;
     bool accept_events;

[pkotwicz, 2014/05/20 00:14:53]

Scott, do you have a suggestion for a comment for |activatable|.
Specifying whether a widget is activatable in InitParams and
WidgetDelegate::CanActivate() is similar but not the same.

In particular, if only WidgetDelegate::CanActivate() returns false, the
WS_EX_NOACTIVATE style in CalculateWindowStylesFromInitParams() is not set. I
have read the MSDN documentation but I am unsure about the practical effect of
WS_EX_NOACTIVATE
http://msdn.microsoft.com/en-us/library/windows/desktop/ms632680(v=vs.85).aspx
(This CL nor https://codereview.chromium.org/286733002/ affect when
WS_EX_NOACTIVATE is set)

[sky, 2014/05/20 15:02:55]

If we correctly query CanActivate at the right places it may not be necessary to
set WS_EX_NOACTIVATE at all. You would have to look into that though.

     Activatable activatable;
     bool keep_on_top;
     bool visible_on_all_workspaces;
     Ownership ownership;
     bool mirror_origin_in_rtl;
     bool has_dropshadow;
     // Specifies that the system default caption and icon should not be
     // rendered, and that the client area should be equivalent to the window
     // area. Only used on some platforms (Windows and Linux).
     bool remove_standard_frame;
@@ skipping 667 matching lines @@
   bool widget_closed_;
 
   // The saved "show" state for this window. See note in SetInitialBounds
   // that explains why we save this.
   ui::WindowShowState saved_show_state_;
 
   // The restored bounds used for the initial show. This is only used if
   // |saved_show_state_| is maximized.
   gfx::Rect initial_restored_bounds_;
 
-  // True if the widget can be activated.
-  bool can_activate_;
-
   // Focus is automatically set to the view provided by the delegate
   // when the widget is shown. Set this value to false to override
   // initial focus for the widget.
   bool focus_on_creation_;
 
   mutable scoped_ptr<InputMethod> input_method_;
 
   // See |is_top_level()| accessor.
   bool is_top_level_;
 
@@ skipping 32 matching lines @@
   bool movement_disabled_;
 
   ScopedObserver<ui::NativeTheme, ui::NativeThemeObserver> observer_manager_;
 
   DISALLOW_COPY_AND_ASSIGN(Widget);
 };
 
 }  // namespace views
 
 #endif  // UI_VIEWS_WIDGET_WIDGET_H_