components/metrics/file_metrics_provider.h - Issue 2938263002: Put BrowserMetrics with embedded profiles into subdir for auto-upload.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/metrics/file_metrics_provider.h

Issue 2938263002: Put BrowserMetrics with embedded profiles into subdir for auto-upload. (Closed)

Patch Set: use std::string::append() where possible Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/metrics/file_metrics_provider.h

diff --git a/components/metrics/file_metrics_provider.h b/components/metrics/file_metrics_provider.h

index a19577b1317a8f856bdc5720747aa5b7ec8096ab..6573475b4d178c3a6b2f70696e2f1ee3573198c8 100644

--- a/components/metrics/file_metrics_provider.h

+++ b/components/metrics/file_metrics_provider.h

@@ -57,7 +57,9 @@ class FileMetricsProvider : public MetricsProvider,

// the ImportantFileWriter) will not get read. Files that have been

// read will be attempted to be deleted; should those files not be

// deletable by this process, it is the reponsibility of the producer

- // to keep the directory pruned in some manner.

+ // to keep the directory pruned in some manner. Added files must have a

+ // timestamp later (not the same or earlier) than the newest file that

+ // already exists or it may be assumed to have been already uploaded.

SOURCE_HISTOGRAMS_ATOMIC_DIR,

// "Active" files may be open by one or more other processes and updated