Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(531)

Issue 293823002: Revert 269361 "Fix WebURLLoaderImpl::Context leak if a pending r..." (Closed)

Created:
6 years, 7 months ago by Elliot Glaysher
Modified:
6 years, 7 months ago
Reviewers:
kcwu
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 269361 "Fix WebURLLoaderImpl::Context leak if a pending r..." This is currently causing a top crasher; tfarina@ rebuilt on a branch without this patch and have confirmed that reverting it fixes the crash. Reverting at the request of the TPMs. > Fix WebURLLoaderImpl::Context leak if a pending request is canceled. > > Now, ResourceDispatcher::CancelPendingRequest will send > ResourceHostMsg_CancelRequest and trigger OnRequestComplete. However, > the request is pending and thus OnRequestComplete will be queued. > > There are at least two problems if OnRequestComplete is not called: > 1. WebURLLoaderImpl::Context will never be released. > 2. request_info->buffer leaks. The buffer holds shared memory handle > (file descriptor). fd leaking may lead to HW video decode failure on > ChromeOS (detail in chrome-os-partner:27911#63) > > This issue is similar to issue 328092. > > BUG=chrome-os-partner:27911, chromium:369221, chromium:369128 > R=jam@chromium.org, mmenke@chromium.org > > Review URL: https://codereview.chromium.org/268423002 BUG=372342 TBR=kcwu@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271504

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -55 lines) Patch
M trunk/src/content/child/resource_dispatcher.h View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/content/child/resource_dispatcher.cc View 4 chunks +0 lines, -54 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Elliot Glaysher
6 years, 7 months ago (2014-05-19 22:34:34 UTC) #1
Elliot Glaysher
6 years, 7 months ago (2014-05-19 22:34:42 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r271504 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698