Compute KernelClosureRepresentationInfo.variableIsUsedInTryOrSync

pkg/compiler/lib/src/js_backend/element_strategy.dart

 // Copyright (c) 2017, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library dart2js.js_backend.element_strategy;
 
 import '../backend_strategy.dart';
 import '../closure.dart' show ClosureConversionTask, ClosureTask;
 import '../common.dart';
 import '../common/codegen.dart';
@@ skipping 16 matching lines @@
 import '../ssa/ssa.dart';
 import '../options.dart';
 import '../universe/world_builder.dart';
 import '../universe/world_impact.dart';
 import '../world.dart';
 
 /// Strategy for using the [Element] model from the resolver as the backend
 /// model.
 class ElementBackendStrategy implements BackendStrategy {
   final Compiler _compiler;
+  final ClosureConversionTask closureDataLookup;
   SourceInformationStrategy _sourceInformationStrategy;
 
-  ElementBackendStrategy(this._compiler);
+  ElementBackendStrategy(this._compiler)
+      : closureDataLookup = new ClosureTask(_compiler);
 
   ClosedWorldRefiner createClosedWorldRefiner(ClosedWorldImpl closedWorld) =>
       closedWorld;
 
   Sorter get sorter => const ElementSorter();
 
   @override
-  ClosureConversionTask createClosureConversionTask(Compiler compiler) =>

[Emily Fortuna, 2017/06/19 17:44:41]

is taking this out the direction you want to go? I went the other way because I
thought I'd match the SsaBuilderTask, but then after Siggi pointed out you were
going the other direction:
https://codereview.chromium.org/2937203002/diff/40001/pkg/compiler/lib/src/ke...

I'm fine doing it this way -- I was just trying to be consistent! :-P

[Johnni Winther, 2017/06/20 10:33:12]

I want to get rid of CompilerTask as base classes. It is just a stop-watch and
should be passed to the actual task.

-      new ClosureTask(compiler);
-
-  @override
   CodegenWorldBuilder createCodegenWorldBuilder(
       NativeBasicData nativeBasicData,
       ClosedWorld closedWorld,
       SelectorConstraintsStrategy selectorConstraintsStrategy) {
     return new ElementCodegenWorldBuilderImpl(
         _compiler.backend.constants,
         closedWorld.elementEnvironment,
         nativeBasicData,
         closedWorld,
         selectorConstraintsStrategy);
@@ skipping 98 matching lines @@
 
   MemberElement get element => resolvedAst.element;
 
   WorldImpact run() {
     registry = new CodegenRegistry(_closedWorld.elementEnvironment, element);
     return _backend.codegen(this, _closedWorld);
   }
 
   String toString() => 'CodegenWorkItem(${resolvedAst.element})';
 }