chrome/browser/engagement/important_sites_util.cc - Issue 2938163002: Store base::Value in ContentSettingPatternSource instead of an enum

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/engagement/important_sites_util.cc

Issue 2938163002: Store base::Value in ContentSettingPatternSource instead of an enum (Closed)

Patch Set: rebased Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/engagement/important_sites_util.cc

diff --git a/chrome/browser/engagement/important_sites_util.cc b/chrome/browser/engagement/important_sites_util.cc

index a9133c9a88485bd6dfa06bd9cf1d62443ffcb214..09dd03258bd673f5cb4291815d598ec5ee951e29 100644

--- a/chrome/browser/engagement/important_sites_util.cc

+++ b/chrome/browser/engagement/important_sites_util.cc

@@ -264,7 +264,7 @@ void PopulateInfoMapWithContentTypeAllowed(

// wildcard patterns.

std::set<GURL> content_origins;

for (const ContentSettingPatternSource& site : content_settings_list) {

- if (site.setting != CONTENT_SETTING_ALLOW)

+ if (site.GetContentSetting() != CONTENT_SETTING_ALLOW)

continue;

MaybePopulateImportantInfoForReason(GURL(site.primary_pattern.ToString()),

&content_origins, reason, output);