chrome/browser/android/preferences/website_preference_bridge.cc - Issue 2938163002: Store base::Value in ContentSettingPatternSource instead of an enum

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/preferences/website_preference_bridge.cc

Issue 2938163002: Store base::Value in ContentSettingPatternSource instead of an enum (Closed)

Patch Set: rebased Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/android/preferences/website_preference_bridge.cc

diff --git a/chrome/browser/android/preferences/website_preference_bridge.cc b/chrome/browser/android/preferences/website_preference_bridge.cc

index e0279b43213ef10ee244e397921f27384aa5e325..66e4753ad8844f6422c279f049557d924b7ed0e3 100644

--- a/chrome/browser/android/preferences/website_preference_bridge.cc

+++ b/chrome/browser/android/preferences/website_preference_bridge.cc

@@ -140,7 +140,7 @@ void GetOrigins(JNIEnv* env,

// Now add all origins that have a non-default setting to the list.

for (const auto& settings_it : all_settings) {

- if (settings_it.setting == default_content_setting)

+ if (settings_it.GetContentSetting() == default_content_setting)

continue;

if (managedOnly &&

HostContentSettingsMap::GetProviderTypeFromSource(settings_it.source) !=