Store base::Value in ContentSettingPatternSource instead of an enum

components/content_settings/core/common/content_settings.mojom

Index: components/content_settings/core/common/content_settings.mojom
diff --git a/components/content_settings/core/common/content_settings.mojom b/components/content_settings/core/common/content_settings.mojom
index 5c4c5d92a929b7ef081380b46180bdb477d0e61e..e7ff22ac0e20d8034bba5b8c633b81b9d5b2fee3 100644
--- a/components/content_settings/core/common/content_settings.mojom
+++ b/components/content_settings/core/common/content_settings.mojom
@@ -4,6 +4,8 @@
 
 module content_settings.mojom;
 
+import "mojo/common/values.mojom";
+
 // This mirrors the C++ type in content_settings_pattern.h.
 struct PatternParts {
   // Lowercase string of the URL scheme to match. This string is empty if the
@@ -59,7 +61,7 @@ enum ContentSetting {
 struct ContentSettingPatternSource {
   ContentSettingsPattern primary_pattern;
   ContentSettingsPattern secondary_pattern;
-  ContentSetting setting;
+  mojo.common.mojom.Value? setting_value;

[nasko, 2017/06/28 20:59:37]

Is the setting value really optional?

[tbansal1, 2017/06/29 15:57:53]

Done.

   string source;
   bool incognito;
 };