chrome/browser/subresource_filter/subresource_filter_content_settings_manager_unittest.cc - Issue 2938163002: Store base::Value in ContentSettingPatternSource instead of an enum

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/subresource_filter/subresource_filter_content_settings_manager_unittest.cc

Issue 2938163002: Store base::Value in ContentSettingPatternSource instead of an enum (Closed)

Patch Set: moar rebase, raymes comments Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/plugins/plugin_utils.cc ('k') | chrome/browser/ui/content_settings/content_setting_bubble_model.cc » ('j') | components/content_settings/core/common/content_settings.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/subresource_filter/subresource_filter_content_settings_manager_unittest.cc

diff --git a/chrome/browser/subresource_filter/subresource_filter_content_settings_manager_unittest.cc b/chrome/browser/subresource_filter/subresource_filter_content_settings_manager_unittest.cc

index f4f6b68452568114bbbeadf63a3690e7f9c94657..736ee27e84010e626431b98b8a47c8880d2dcb80 100644

--- a/chrome/browser/subresource_filter/subresource_filter_content_settings_manager_unittest.cc

+++ b/chrome/browser/subresource_filter/subresource_filter_content_settings_manager_unittest.cc

@@ -77,7 +77,7 @@ class SubresourceFilterContentSettingsManagerTest : public testing::Test {

for (const auto& it : host_settings) {

// Need GURL conversion to get rid of unnecessary default ports.

if (GURL(it.primary_pattern.ToString()) == url_with_empty_path)

- return it.setting;

+ return it.GetContentSetting();

}

return CONTENT_SETTING_DEFAULT;

}