Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1732)

Unified Diff: chrome/browser/engagement/important_sites_util.cc

Issue 2938163002: Store base::Value in ContentSettingPatternSource instead of an enum (Closed)
Patch Set: ps Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/engagement/important_sites_util.cc
diff --git a/chrome/browser/engagement/important_sites_util.cc b/chrome/browser/engagement/important_sites_util.cc
index d79b9f79a9652fb0dc059d883a8967ff163d959f..96372cebe1f419172b82ed916f0a323a25e0a4bc 100644
--- a/chrome/browser/engagement/important_sites_util.cc
+++ b/chrome/browser/engagement/important_sites_util.cc
@@ -26,6 +26,7 @@
#include "components/bookmarks/browser/bookmark_model.h"
#include "components/content_settings/core/browser/host_content_settings_map.h"
#include "components/content_settings/core/common/content_settings.h"
+#include "components/content_settings/core/common/content_settings_utils.h"
#include "components/pref_registry/pref_registry_syncable.h"
#include "components/prefs/pref_service.h"
#include "components/prefs/scoped_user_pref_update.h"
@@ -264,8 +265,10 @@ void PopulateInfoMapWithContentTypeAllowed(
// wildcard patterns.
std::set<GURL> content_origins;
for (const ContentSettingPatternSource& site : content_settings_list) {
- if (site.setting != CONTENT_SETTING_ALLOW)
+ if (content_settings::ValueToContentSetting(site.setting_value.get()) !=
+ CONTENT_SETTING_ALLOW) {
continue;
+ }
MaybePopulateImportantInfoForReason(GURL(site.primary_pattern.ToString()),
&content_origins, reason, output);
}

Powered by Google App Engine
This is Rietveld 408576698