Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Unified Diff: chrome/browser/browsing_data/chrome_browsing_data_remover_delegate_unittest.cc

Issue 2938163002: Store base::Value in ContentSettingPatternSource instead of an enum (Closed)
Patch Set: ps Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/browsing_data/chrome_browsing_data_remover_delegate_unittest.cc
diff --git a/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate_unittest.cc b/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate_unittest.cc
index e097b55131a3c8ac2b3c96b5257f09dd6da4f90a..69ddd8c96b23fd8f89da301b040afac08c99a0b5 100644
--- a/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate_unittest.cc
+++ b/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate_unittest.cc
@@ -43,6 +43,7 @@
#include "components/content_settings/core/browser/host_content_settings_map.h"
#include "components/content_settings/core/common/content_settings.h"
#include "components/content_settings/core/common/content_settings_pattern.h"
+#include "components/content_settings/core/common/content_settings_utils.h"
#include "components/domain_reliability/clear_mode.h"
#include "components/domain_reliability/monitor.h"
#include "components/domain_reliability/service.h"
@@ -1697,12 +1698,14 @@ TEST_F(ChromeBrowsingDataRemoverDelegateTest, RemoveContentSettings) {
EXPECT_EQ(ContentSettingsPattern::FromURLNoWildcard(kOrigin1),
host_settings[0].primary_pattern)
<< host_settings[0].primary_pattern.ToString();
- EXPECT_EQ(CONTENT_SETTING_ALLOW, host_settings[0].setting);
+ EXPECT_EQ(CONTENT_SETTING_ALLOW, content_settings::ValueToContentSetting(
+ host_settings[0].setting_value.get()));
// And the wildcard.
EXPECT_EQ(ContentSettingsPattern::Wildcard(),
host_settings[1].primary_pattern)
<< host_settings[1].primary_pattern.ToString();
- EXPECT_EQ(CONTENT_SETTING_ASK, host_settings[1].setting);
+ EXPECT_EQ(CONTENT_SETTING_ASK, content_settings::ValueToContentSetting(
+ host_settings[1].setting_value.get()));
// There should also only be one setting for origin3
map->GetSettingsForOneType(CONTENT_SETTINGS_TYPE_NOTIFICATIONS, std::string(),
@@ -1711,12 +1714,14 @@ TEST_F(ChromeBrowsingDataRemoverDelegateTest, RemoveContentSettings) {
EXPECT_EQ(ContentSettingsPattern::FromURLNoWildcard(kOrigin3),
host_settings[0].primary_pattern)
<< host_settings[0].primary_pattern.ToString();
- EXPECT_EQ(CONTENT_SETTING_ALLOW, host_settings[0].setting);
+ EXPECT_EQ(CONTENT_SETTING_ALLOW, content_settings::ValueToContentSetting(
+ host_settings[0].setting_value.get()));
// And the wildcard.
EXPECT_EQ(ContentSettingsPattern::Wildcard(),
host_settings[1].primary_pattern)
<< host_settings[1].primary_pattern.ToString();
- EXPECT_EQ(CONTENT_SETTING_ASK, host_settings[1].setting);
+ EXPECT_EQ(CONTENT_SETTING_ASK, content_settings::ValueToContentSetting(
+ host_settings[1].setting_value.get()));
BlockUntilOriginDataRemoved(
base::Time(), base::Time::Max(),
@@ -1730,7 +1735,8 @@ TEST_F(ChromeBrowsingDataRemoverDelegateTest, RemoveContentSettings) {
EXPECT_EQ(ContentSettingsPattern::Wildcard(),
host_settings[0].primary_pattern)
<< host_settings[0].primary_pattern.ToString();
- EXPECT_EQ(CONTENT_SETTING_ASK, host_settings[0].setting);
+ EXPECT_EQ(CONTENT_SETTING_ASK, content_settings::ValueToContentSetting(
+ host_settings[0].setting_value.get()));
map->GetSettingsForOneType(CONTENT_SETTINGS_TYPE_NOTIFICATIONS, std::string(),
&host_settings);
@@ -1738,7 +1744,8 @@ TEST_F(ChromeBrowsingDataRemoverDelegateTest, RemoveContentSettings) {
EXPECT_EQ(ContentSettingsPattern::Wildcard(),
host_settings[0].primary_pattern)
<< host_settings[0].primary_pattern.ToString();
- EXPECT_EQ(CONTENT_SETTING_ASK, host_settings[0].setting);
+ EXPECT_EQ(CONTENT_SETTING_ASK, content_settings::ValueToContentSetting(
+ host_settings[0].setting_value.get()));
}
TEST_F(ChromeBrowsingDataRemoverDelegateTest, RemoveDurablePermission) {
@@ -1777,13 +1784,15 @@ TEST_F(ChromeBrowsingDataRemoverDelegateTest, RemoveDurablePermission) {
EXPECT_EQ(ContentSettingsPattern::FromURLNoWildcard(kOrigin1),
host_settings[0].primary_pattern)
<< host_settings[0].primary_pattern.ToString();
- EXPECT_EQ(CONTENT_SETTING_ALLOW, host_settings[0].setting);
+ EXPECT_EQ(CONTENT_SETTING_ALLOW, content_settings::ValueToContentSetting(
+ host_settings[0].setting_value.get()));
// And our wildcard.
EXPECT_EQ(ContentSettingsPattern::Wildcard(),
host_settings[1].primary_pattern)
<< host_settings[1].primary_pattern.ToString();
- EXPECT_EQ(CONTENT_SETTING_ASK, host_settings[1].setting);
+ EXPECT_EQ(CONTENT_SETTING_ASK, content_settings::ValueToContentSetting(
+ host_settings[1].setting_value.get()));
}
TEST_F(ChromeBrowsingDataRemoverDelegateTest,

Powered by Google App Engine
This is Rietveld 408576698