Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Side by Side Diff: chrome/browser/android/preferences/website_preference_bridge.cc

Issue 2938163002: Store base::Value in ContentSettingPatternSource instead of an enum (Closed)
Patch Set: ps Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/android/preferences/website_preference_bridge.h" 5 #include "chrome/browser/android/preferences/website_preference_bridge.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <string> 8 #include <string>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 23 matching lines...) Expand all
34 #include "chrome/browser/permissions/permission_manager.h" 34 #include "chrome/browser/permissions/permission_manager.h"
35 #include "chrome/browser/permissions/permission_uma_util.h" 35 #include "chrome/browser/permissions/permission_uma_util.h"
36 #include "chrome/browser/permissions/permission_util.h" 36 #include "chrome/browser/permissions/permission_util.h"
37 #include "chrome/browser/profiles/profile.h" 37 #include "chrome/browser/profiles/profile.h"
38 #include "chrome/browser/profiles/profile_manager.h" 38 #include "chrome/browser/profiles/profile_manager.h"
39 #include "chrome/browser/storage/storage_info_fetcher.h" 39 #include "chrome/browser/storage/storage_info_fetcher.h"
40 #include "chrome/browser/usb/usb_chooser_context.h" 40 #include "chrome/browser/usb/usb_chooser_context.h"
41 #include "chrome/browser/usb/usb_chooser_context_factory.h" 41 #include "chrome/browser/usb/usb_chooser_context_factory.h"
42 #include "components/content_settings/core/browser/cookie_settings.h" 42 #include "components/content_settings/core/browser/cookie_settings.h"
43 #include "components/content_settings/core/browser/host_content_settings_map.h" 43 #include "components/content_settings/core/browser/host_content_settings_map.h"
44 #include "components/content_settings/core/common/content_settings_utils.h"
44 #include "content/public/browser/browser_thread.h" 45 #include "content/public/browser/browser_thread.h"
45 #include "content/public/browser/storage_partition.h" 46 #include "content/public/browser/storage_partition.h"
46 #include "jni/WebsitePreferenceBridge_jni.h" 47 #include "jni/WebsitePreferenceBridge_jni.h"
47 #include "net/base/registry_controlled_domains/registry_controlled_domain.h" 48 #include "net/base/registry_controlled_domains/registry_controlled_domain.h"
48 #include "storage/browser/quota/quota_manager.h" 49 #include "storage/browser/quota/quota_manager.h"
49 #include "storage/common/quota/quota_status_code.h" 50 #include "storage/common/quota/quota_status_code.h"
50 #include "url/origin.h" 51 #include "url/origin.h"
51 #include "url/url_constants.h" 52 #include "url/url_constants.h"
52 53
53 using base::android::ConvertJavaStringToUTF8; 54 using base::android::ConvertJavaStringToUTF8;
(...skipping 78 matching lines...) Expand 10 before | Expand all | Expand 10 after
132 CONTENT_SETTINGS_TYPE_PERMISSION_AUTOBLOCKER_DATA, std::string(), 133 CONTENT_SETTINGS_TYPE_PERMISSION_AUTOBLOCKER_DATA, std::string(),
133 &embargo_settings); 134 &embargo_settings);
134 ContentSetting default_content_setting = content_settings_map-> 135 ContentSetting default_content_setting = content_settings_map->
135 GetDefaultContentSetting(content_type, NULL); 136 GetDefaultContentSetting(content_type, NULL);
136 137
137 // Use a vector since the overall number of origins should be small. 138 // Use a vector since the overall number of origins should be small.
138 std::vector<std::string> seen_origins; 139 std::vector<std::string> seen_origins;
139 140
140 // Now add all origins that have a non-default setting to the list. 141 // Now add all origins that have a non-default setting to the list.
141 for (const auto& settings_it : all_settings) { 142 for (const auto& settings_it : all_settings) {
142 if (settings_it.setting == default_content_setting) 143 if (content_settings::ValueToContentSetting(
144 settings_it.setting_value.get()) == default_content_setting) {
143 continue; 145 continue;
146 }
144 if (managedOnly && 147 if (managedOnly &&
145 HostContentSettingsMap::GetProviderTypeFromSource(settings_it.source) != 148 HostContentSettingsMap::GetProviderTypeFromSource(settings_it.source) !=
146 HostContentSettingsMap::ProviderType::POLICY_PROVIDER) { 149 HostContentSettingsMap::ProviderType::POLICY_PROVIDER) {
147 continue; 150 continue;
148 } 151 }
149 const std::string origin = settings_it.primary_pattern.ToString(); 152 const std::string origin = settings_it.primary_pattern.ToString();
150 const std::string embedder = settings_it.secondary_pattern.ToString(); 153 const std::string embedder = settings_it.secondary_pattern.ToString();
151 154
152 ScopedJavaLocalRef<jstring> jembedder; 155 ScopedJavaLocalRef<jstring> jembedder;
153 if (embedder != origin) 156 if (embedder != origin)
(...skipping 674 matching lines...) Expand 10 before | Expand all | Expand 10 after
828 const JavaParamRef<jstring>& jorigin) { 831 const JavaParamRef<jstring>& jorigin) {
829 GURL url(ConvertJavaStringToUTF8(env, jorigin)); 832 GURL url(ConvertJavaStringToUTF8(env, jorigin));
830 return !!GetHostContentSettingsMap(false)->GetWebsiteSetting( 833 return !!GetHostContentSettingsMap(false)->GetWebsiteSetting(
831 url, GURL(), CONTENT_SETTINGS_TYPE_ADS_DATA, std::string(), nullptr); 834 url, GURL(), CONTENT_SETTINGS_TYPE_ADS_DATA, std::string(), nullptr);
832 } 835 }
833 836
834 // Register native methods 837 // Register native methods
835 bool RegisterWebsitePreferenceBridge(JNIEnv* env) { 838 bool RegisterWebsitePreferenceBridge(JNIEnv* env) {
836 return RegisterNativesImpl(env); 839 return RegisterNativesImpl(env);
837 } 840 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698